From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 597531FF138 for ; Mon, 20 Jul 2026 10:22:38 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 31E0021487; Mon, 20 Jul 2026 10:22:38 +0200 (CEST) Message-ID: <5ba2ff31-ad41-40f8-ac74-1d6b70503f72@proxmox.com> Date: Mon, 20 Jul 2026 10:22:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: David Riley Subject: Re: [PATCH proxmox-widget-toolkit v2 04/10] fix #7294: css: theme: add opacity override for pool VNet icon To: Daniel Kral , pve-devel@lists.proxmox.com References: <20260626131035.112374-1-d.riley@proxmox.com> <20260626131035.112374-5-d.riley@proxmox.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784535700117 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.127 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: I6PX7EMDT2OQLSJLXKXAQDEJ2HPXQ7HU X-Message-ID-Hash: I6PX7EMDT2OQLSJLXKXAQDEJ2HPXQ7HU X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: comments inline. On 7/3/26 3:30 PM, Daniel Kral wrote: > On Fri Jun 26, 2026 at 3:10 PM CEST, David Riley wrote: >> Add opacity adjustments for the `fa-network-wired` icon used by pool >> networks. >> >> The light/base theme lowers the icons opacity to simulate a light grey >> color that matches other configuration elements. This override >> restores the opacity to 1 in the dark theme so the native white SVG >> remains clearly visible against the dark background. >> >> Signed-off-by: David Riley > existing - so not related to the series directly - but the VM and CT > icons seem to also have lower opacity The opacity of the VMs and CTs depends on their state. If they are turned off they are lighter and if they are turned on the icon turns darker. In my opinion that's actual quite neat. I'll remove the whitespaces in v3. > With the trailing white spaces removed: > > Reviewed-by: Daniel Kral > >> --- >> src/proxmox-dark/scss/other/_icons.scss | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss >> index ad08906..3712094 100644 >> --- a/src/proxmox-dark/scss/other/_icons.scss >> +++ b/src/proxmox-dark/scss/other/_icons.scss >> @@ -250,3 +250,15 @@ >> .usage { >> background-color: $icon-color; >> } >> + >> +// fa-network-wired override for dark mode. >> +// The base/light theme lowers the opacity to simulate a light grey > nit: trailing white space > >> +// color. This restores the opacity to 1 so the icon remains white and >> +// clearly visible in the dark mode > nit: trailing white space > >> +.x-fa-pool-net:before { >> + opacity: 1; >> +} >> + >> +.x-fa-pool-net-grid:before { >> + opacity: 1; >> +} >