Re: [PATCH pve-network v2 07/10] fix #7294: sdn: vnet: update pool members on vnet migration and deletion

[David Riley <d.riley@proxmox.com>]

comment inline.

On 7/6/26 2:30 PM, Daniel Kral wrote:
> On Fri Jun 26, 2026 at 3:10 PM CEST, David Riley wrote:
>> Update or remove corresponding resource pool allocations in user.cfg
>> whenever a VNet is altered or deleted. This prevents stale paths and
>> dangling references from breaking the configuration integrity.
>>
>> Link:https://bugzilla.proxmox.com/show_bug.cgi?id=7294
>> Signed-off-by: David Riley<d.riley@proxmox.com>
>> ---
>>   src/PVE/Network/SDN.pm | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
>> index cd563d2..81f5d9a 100644
>> --- a/src/PVE/Network/SDN.pm
>> +++ b/src/PVE/Network/SDN.pm
>> @@ -261,11 +261,26 @@ sub cleanup {
>>           PVE::AccessControl::migrate_sdn_resource_access($vnet_move_paths);
>>       }
>>   
>> +    for my $move (@$vnet_move_paths) {
>> +        my ($src_type, $src_zone, $vnet) = @{ $move->{src_path} };
>> +        my ($dest_type, $dest_zone, $dest_vnet) = @{ $move->{dest_path} };
>> +
>> +        if (defined($src_type) && $src_type eq 'zones' && $src_zone && $vnet && $dest_zone) {
> Will there ever be any VNet paths to be moved, that are not zones?
>
> Otherwise, I think the checks are a little overkill here. Since there
> already quite a lot of definedness checks in diff_vnets(), these might
> be redundant here.


No and you are totally right these checks don't add anything here.
I'll remove them.

>> +            PVE::AccessControl::migrate_vnet_zone_in_pool($src_zone, $dest_zone, $vnet);
>> +        }
>> +    }
>> +
>>       my @paths_to_delete = (@$vnet_delete_paths, @$route_map_paths, @$generic_paths);
>>       if (@paths_to_delete) {
>>           PVE::AccessControl::remove_sdn_resource_access(\@paths_to_delete);
>>       }
>>   
>> +    for my $path (@$vnet_delete_paths) {
>> +        my ($type, $zone, $vnet) = @$path;
>> +        if ($type && $type eq 'zones' && $zone && $vnet) {
>> +            PVE::AccessControl::remove_vnet_from_pool($zone, $vnet);
>> +        }
> Same here.
>
>> +    }
>>   }
>>   
>>   sub diff_generic_resources {
>
>
>