Re: [PATCH pve-cluster v2 09/10] fix #7294: cluster: helpers: add cluster-wide version assertion

[David Riley <d.riley@proxmox.com>]

Thanks for the feedback.
I'll address these nits in v3.

On 7/6/26 3:00 PM, Daniel Kral wrote:
> On Fri Jun 26, 2026 at 3:10 PM CEST, David Riley wrote:
>> Add function to assert a minimum version requirement for the whole
>> cluster.
>>
>> Evaluates against the cluster configuration. Dies if any node is
>> offline, or running an older version, ensuring cluster-wide feature
>> compatibility before allowing an operation to proceed.
>>
>> Prevents older nodes from truncating newly structured configuration
>> entries.
>>
>> Link:https://bugzilla.proxmox.com/show_bug.cgi?id=7294
>> Signed-off-by: David Riley<d.riley@proxmox.com>
>> ---
>>   src/PVE/Cluster.pm | 43 +++++++++++++++++++++++++++++++++++++++++--
>>   1 file changed, 41 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
>> index 034b78c..3ecde03 100644
>> --- a/src/PVE/Cluster.pm
>> +++ b/src/PVE/Cluster.pm
>> @@ -20,7 +20,7 @@ use PVE::IPCC;
>>   use PVE::JSONSchema;
>>   use PVE::Network;
>>   use PVE::SafeSyslog;
>> -use PVE::Tools qw(run_command);
>> +use PVE::Tools qw(run_command pvecfg_min_version);
>>   
>>   use PVE::Cluster::IPCConst;
>>   
>> @@ -30,7 +30,9 @@ our @EXPORT_OK = qw(
>>       cfs_read_file
>>       cfs_write_file
>>       cfs_register_file
>> -    cfs_lock_file);
>> +    cfs_lock_file
>> +    assert_min_cluster_version
> This export is not needed anymore if the function is always called as
> PVE::Cluster::assert_min_cluster_version().


You are right. I'll remove it.

>
>> +);
>>   
>>   # x509 certificate utils
>>   
>> @@ -929,4 +931,41 @@ sub cfs_rename_db_unsafe {
>>       rename $dbfile, "$dbfile.$ctime.bak" or warn "failed to rename old config database - $!\n";
>>   }
>>   
>> +# Asserts that all configured nodes in the cluster meet a minimum version requirement.
>> +# Evaluates against the full, static cluster node list rather than only live nodes.
>> +# Aborts if any node is offline, unreadable, or running an
>> +# outdated version, preventing partial feature rollouts from corrupting cluster state.
>> +# NOTE: Uses PVE::Tools::pvecfg_min_version, which currently checks basic major.minor.release
>> +# triples. If gatekeeping a feature right around a major release transition, be aware that it
>> +# does not yet lexically sort trailing Debian revision suffixes (e.g., distinguishing '9.0.0' as
>> +# newer than '9.0.0~22').
>> +sub assert_min_cluster_version {
>> +    my ($major, $minor, $release) = @_;
>> +
>> +    my $nodestat = get_node_kv('version-info') || {};
>> +    my $nodelist = get_nodelist() || [];
> nit: get_node_kv() will always return an empty hash ref {} and
>       get_nodelist() will always return an empty array ref [], so the
>       fallbacks aren't really needed
>
>> +
>> +    for my $node (sort @$nodelist) {
>> +        my $raw_json = $nodestat->{$node};
>> +
>> +        if (!defined($raw_json)) {
>> +            die "cannot execute operation: cluster node '$node' is offline or not reporting its"
>> +                . " version. All nodes must be online to verify cluster-wide feature support.\n";
>> +        }
>> +
>> +        my $vinfo = eval { decode_json($raw_json) };
>> +        if ($@ || !$vinfo || !$vinfo->{version}) {
>> +            die "cannot execute operation: failed to parse cluster version string for node"
>> +                . " '$node'.\n";
>> +        }
>> +
>> +        if (!pvecfg_min_version($vinfo->{version}, $major, $minor, $release)) {
>> +            die "cannot execute operation: cluster node '$node' runs an older version of Proxmox"
>> +                . " VE ($vinfo->{version}) than the required $major.$minor.$release. Please"
>> +                . " upgrade all nodes first.\n";
>> +        }
>> +    }
>> +    return 1;
>> +}
>> +
>>   1;
> Modulo the nits, consider this:
>
> Reviewed-by: Daniel Kral<d.kral@proxmox.com>
>
>
>
>