public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ludwig <christian_ludwig@genua.de>
To: <pve-devel@lists.proxmox.com>
Subject: [PATCH pve-manager v4 18/20] ui: migrate: refuse migration with a local custom firmware image
Date: Thu, 19 Nov 2026 15:14:32 +0100	[thread overview]
Message-ID: <27e926cbd42453d9722d11f301f6dd7e2502d010.1795092172.git.christian_ludwig@genua.de> (raw)
In-Reply-To: <cover.1795092172.git.christian_ludwig@genua.de>

A custom firmware image is not owned by the VM and never copied to the
target node, so the backend refuses the migration unless the image is on
a shared storage. Show this as an error in the preconditions, rather than
offering to migrate it like a local disk.

Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
---
 www/manager6/window/Migrate.js | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 15ce34f8..8d70f4c6 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -370,7 +370,16 @@ Ext.define('PVE.window.Migrate', {
             if (migrateStats.local_disks.length) {
                 let volumeTypes = new Set();
                 migrateStats.local_disks.forEach(function (disk) {
-                    if (disk.cdrom && disk.cdrom === 1) {
+                    if (disk.is_firmware) {
+                        migration.possible = false;
+                        migration.preconditions.push({
+                            text: Ext.String.format(
+                                gettext('Cannot migrate VM with local custom firmware image: {0}'),
+                                disk.volid,
+                            ),
+                            severity: 'error',
+                        });
+                    } else if (disk.cdrom && disk.cdrom === 1) {
                         if (!disk.volid.includes('vm-' + vm.get('vmid') + '-cloudinit')) {
                             migration.possible = false;
                             migration.preconditions.push({
@@ -391,7 +400,9 @@ Ext.define('PVE.window.Migrate', {
                         migration['with-local-disks'] = 1;
                         migration.preconditions.push({ text, severity: 'warning' });
                     }
-                    volumeTypes.add(disk.is_vmstate ? 'vm-state' : 'vm-vol');
+                    if (!disk.is_firmware) {
+                        volumeTypes.add(disk.is_vmstate ? 'vm-state' : 'vm-vol');
+                    }
                 });
                 migration.volumeTypes = [...volumeTypes].sort();
             }
-- 
2.34.1




  parent reply	other threads:[~2026-11-19 14:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 14:14 [PATCH v4 00/20] Support for custom EFI firmware Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 01/20] plugin: add efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 02/20] test: get_subdir: cover the " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 03/20] plugins: allow the efi-firmware content type on file based storages Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 04/20] plugin: allow overriding the efi-firmware directory Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 05/20] plugin: support efi-firmware volumes in volume export and import Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 06/20] api: status: support efi-firmware in upload and download-url Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 07/20] test: volume access: cover efi-firmware volumes Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 08/20] test: list volumes: " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 09/20] test: cover efi-firmware volumes in parse_volname and path_to_volume_id Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 10/20] config: define bios schema as property-string Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 11/20] bios: add a custom firmware sub-property Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 12/20] api: check the custom firmware of the bios option Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 13/20] test: custom firmware in " Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 14/20] test: custom firmware volumes in replication and migration Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 15/20] ui: storage: add efi-firmware content type support Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 16/20] ui: form: support other content types in the ISO selector Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 17/20] ui: qemu: allow selecting a custom EFI firmware image Christian Ludwig
2026-11-19 14:14 ` Christian Ludwig [this message]
2026-11-19 14:14 ` [PATCH pve-docs v4 19/20] pvesm: document the efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 20/20] qm: document the custom firmware of the bios option Christian Ludwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27e926cbd42453d9722d11f301f6dd7e2502d010.1795092172.git.christian_ludwig@genua.de \
    --to=christian_ludwig@genua.de \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal