From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1E3B21FF0DE for ; Thu, 19 Nov 2026 15:16:04 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D4E1C21706; Thu, 19 Nov 2026 15:15:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=genua.de; s=202307; t=1795097673; bh=CZQVz1x73eliLw3jWtOdQJzzvi2vC+OFmBon0Jo7XTs=; h=Date:From:To:Subject:References:In-Reply-To:From; b=AUrAKJ81VewgE8onh+NvqKFrYPDLhnOi95aqoy0lPKa6fOF1iuvB7Xy8I+nQ+9OwS c9WY+nmROVvomDxdfF/UzKERDtFpxjeg1HxD9nyLfC3dg430gX2b8zcKedjElVgH5R Idwl/RL+F3sPoM6scQxeyhhZ9f4nNjeJDWWKgyScR7Ik6OEOEfEOHNth6Y+KI8IMSD N1H6R0YWqHDVAtvuHR0FAA8o6LC7TqxtPvomEV4Tsnl9jijk3MUtQfvZQlKij81RZ9 80wmq8AJehpBnMKB++ZVBnRT/Ssf9hiWjug/7GP3hmQywco6sN3+vz1O4/haespvnM sOLY8+ld+mNbA== Date: Thu, 19 Nov 2026 15:14:32 +0100 From: Christian Ludwig To: Subject: [PATCH pve-manager v4 18/20] ui: migrate: refuse migration with a local custom firmware image Message-ID: <27e926cbd42453d9722d11f301f6dd7e2502d010.1795092172.git.christian_ludwig@genua.de> References: MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [192.168.217.185] X-ClientProxiedBy: kch1-mta09.win.genua.de (10.208.16.109) To kch1-mta07.win.genua.de (10.208.16.107) Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record UNPARSEABLE_RELAY 0.001 Informational: message has unparseable relay lines Message-ID-Hash: MFMPRTSME332P6YQ7NRGQXZI7ZW4QVPZ X-Message-ID-Hash: MFMPRTSME332P6YQ7NRGQXZI7ZW4QVPZ X-MailFrom: christian_ludwig@genua.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A custom firmware image is not owned by the VM and never copied to the target node, so the backend refuses the migration unless the image is on a shared storage. Show this as an error in the preconditions, rather than offering to migrate it like a local disk. Signed-off-by: Christian Ludwig --- www/manager6/window/Migrate.js | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js index 15ce34f8..8d70f4c6 100644 --- a/www/manager6/window/Migrate.js +++ b/www/manager6/window/Migrate.js @@ -370,7 +370,16 @@ Ext.define('PVE.window.Migrate', { if (migrateStats.local_disks.length) { let volumeTypes = new Set(); migrateStats.local_disks.forEach(function (disk) { - if (disk.cdrom && disk.cdrom === 1) { + if (disk.is_firmware) { + migration.possible = false; + migration.preconditions.push({ + text: Ext.String.format( + gettext('Cannot migrate VM with local custom firmware image: {0}'), + disk.volid, + ), + severity: 'error', + }); + } else if (disk.cdrom && disk.cdrom === 1) { if (!disk.volid.includes('vm-' + vm.get('vmid') + '-cloudinit')) { migration.possible = false; migration.preconditions.push({ @@ -391,7 +400,9 @@ Ext.define('PVE.window.Migrate', { migration['with-local-disks'] = 1; migration.preconditions.push({ text, severity: 'warning' }); } - volumeTypes.add(disk.is_vmstate ? 'vm-state' : 'vm-vol'); + if (!disk.is_firmware) { + volumeTypes.add(disk.is_vmstate ? 'vm-state' : 'vm-vol'); + } }); migration.volumeTypes = [...volumeTypes].sort(); } -- 2.34.1