From: Christian Ludwig <christian_ludwig@genua.de>
To: <pve-devel@lists.proxmox.com>
Subject: [PATCH pve-storage v4 09/20] test: cover efi-firmware volumes in parse_volname and path_to_volume_id
Date: Thu, 19 Nov 2026 15:14:18 +0100 [thread overview]
Message-ID: <cba5395024bdeab69626d855c6d860fff6f98210.1795092172.git.christian_ludwig@genua.de> (raw)
In-Reply-To: <cover.1795092172.git.christian_ludwig@genua.de>
Check that only names with the safe character class and the '.fd'
extension are recognized as efi-firmware volumes.
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
---
src/test/parse_volname_test.pm | 18 ++++++++++++++++++
src/test/path_to_volume_id_test.pm | 13 +++++++++++++
2 files changed, 31 insertions(+)
diff --git a/src/test/parse_volname_test.pm b/src/test/parse_volname_test.pm
index b8a4a21..9492d87 100644
--- a/src/test/parse_volname_test.pm
+++ b/src/test/parse_volname_test.pm
@@ -252,6 +252,24 @@ my $tests = [
volname => "import/test.foo",
expected => "unable to parse directory volume name 'import/test.foo'\n",
},
+ {
+ description => 'Failed match: EFI firmware, wrong extension',
+ volname => 'efi-firmware/custom-ovmf-code.raw',
+ expected =>
+ "unable to parse directory volume name 'efi-firmware/custom-ovmf-code.raw'\n",
+ },
+ {
+ description => 'Failed match: EFI firmware, upper case extension',
+ volname => 'efi-firmware/custom-ovmf-code.FD',
+ expected =>
+ "unable to parse directory volume name 'efi-firmware/custom-ovmf-code.FD'\n",
+ },
+ {
+ description => 'Failed match: EFI firmware, unsafe characters',
+ volname => 'efi-firmware/custom ovmf code.fd',
+ expected =>
+ "unable to parse directory volume name 'efi-firmware/custom ovmf code.fd'\n",
+ },
];
# create more test cases for VM disk images matches
diff --git a/src/test/path_to_volume_id_test.pm b/src/test/path_to_volume_id_test.pm
index ff162b1..d121e3d 100644
--- a/src/test/path_to_volume_id_test.pm
+++ b/src/test/path_to_volume_id_test.pm
@@ -29,6 +29,7 @@ my $scfg = {
'iso' => 1,
'backup' => 1,
'vztmpl' => 1,
+ 'efi-firmware' => 1,
},
},
},
@@ -185,6 +186,13 @@ my @tests = (
'import', 'local:import/import.ovf',
],
},
+ {
+ description => 'EFI firmware, fd',
+ volname => "$storage_dir/efi-firmware/custom-ovmf-code.fd",
+ expected => [
+ 'efi-firmware', 'local:efi-firmware/custom-ovmf-code.fd',
+ ],
+ },
# no matches, path or files with failures
{
@@ -232,6 +240,11 @@ my @tests = (
volname => "$storage_dir/import/test.foo",
expected => [''],
},
+ {
+ description => 'EFI firmware, wrong extension',
+ volname => "$storage_dir/efi-firmware/custom-ovmf-code.raw",
+ expected => [''],
+ },
);
plan tests => scalar @tests + 1;
--
2.34.1
next prev parent reply other threads:[~2026-11-19 14:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 14:14 [PATCH v4 00/20] Support for custom EFI firmware Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 01/20] plugin: add efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 02/20] test: get_subdir: cover the " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 03/20] plugins: allow the efi-firmware content type on file based storages Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 04/20] plugin: allow overriding the efi-firmware directory Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 05/20] plugin: support efi-firmware volumes in volume export and import Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 06/20] api: status: support efi-firmware in upload and download-url Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 07/20] test: volume access: cover efi-firmware volumes Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 08/20] test: list volumes: " Christian Ludwig
2026-11-19 14:14 ` Christian Ludwig [this message]
2026-11-19 14:14 ` [PATCH qemu-server v4 10/20] config: define bios schema as property-string Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 11/20] bios: add a custom firmware sub-property Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 12/20] api: check the custom firmware of the bios option Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 13/20] test: custom firmware in " Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 14/20] test: custom firmware volumes in replication and migration Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 15/20] ui: storage: add efi-firmware content type support Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 16/20] ui: form: support other content types in the ISO selector Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 17/20] ui: qemu: allow selecting a custom EFI firmware image Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 18/20] ui: migrate: refuse migration with a local custom " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 19/20] pvesm: document the efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 20/20] qm: document the custom firmware of the bios option Christian Ludwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba5395024bdeab69626d855c6d860fff6f98210.1795092172.git.christian_ludwig@genua.de \
--to=christian_ludwig@genua.de \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox