From: Christian Ludwig <christian_ludwig@genua.de>
To: <pve-devel@lists.proxmox.com>
Subject: [PATCH v4 00/20] Support for custom EFI firmware
Date: Thu, 19 Nov 2026 15:14:05 +0100 [thread overview]
Message-ID: <cover.1795092172.git.christian_ludwig@genua.de> (raw)
Hi,
here is an updated patch series that brings support for custom UEFI
firmware images. You can find the v3 series at [1], the v2 series at [2]
and the v1 series at [3] for reference.
In Confidential Computing the aim is to not trust the hypervisor, yet it
runs its bundled firmware in each VM. Some VM appliances also ship their
own firmware images. This series allows to bring your own firmware for
OVMF based VMs.
Today the Proxmox-VE API allows to import a custom efidisk0 (EFIVAR)
already. EFI firmware and EFIVAR data have to match. Otherwise, the VM
might not boot anymore. Therefore, with this series you can set a custom
EFI firmware via the API, along with a custom efidisk. But these are two
steps. And there is no safety net. The GUI is missing a way to set a
custom EFIVAR. So this series only allows to set a custom firmware image
for confidential computing VMs that do not need EFIVAR storage. The
defaults do not change.
pve-storage:
- Declares the new 'efi-firmware' content type for file based storage.
- Provides upload/download API. File names are restricted to the safe
character set, because they are used as sub-properties in the GUI.
File extensions are restricted to '.fd'. So the efi-firmware storage
can host other types as well in the future.
qemu-server:
- Extends the 'bios' property with an optional 'firmware' sub-property
with an efi-firmware storage location.
- The 'firmware' sub-property is only allowed to be set for OVMF based
VMs.
- Adds API plumbing. The image is never replicated or copied, so
migration requires it on a shared storage.
pve-manager:
- Adds UI plumbing for the 'efi-firmware' storage content type.
- Extends the BIOS chooser dialog with an 'OVMF (custom)' option to
select the firmware sub-property.
- Restricts custom firmware selection to confidential computing VMs.
pve-docs:
- Adds a custom firmware subsection in the BIOS section.
Changes in v4:
- Rebased onto current master and adapted to the changed storage API:
guest volumes now have their own volume types ('vm-vol', 'vm-state',
'ct-vol'), with 'images' and 'rootdir' as generic content types, and
content types are checked with content_allows(). efi-firmware volumes
are not guest volumes, so they behave as before.
pve-storage:
- Collected Reviewed-by tags.
- plugin: add efi-firmware content type
- Mention efi-firmware in the comment above $get_subdir_files.
- Carry the positive parse_volname test, as upstream re-enabled the
check that every content type with a directory has one.
- New patch "plugin: allow overriding the efi-firmware directory"
- The directory overrides of 'content-dirs' did not accept content
types with hyphens.
- Volume types of guests are refused, as they share the directory of
their generic type.
- api: status: support efi-firmware in upload and download-url
- assert_efi_firmware_content(): tell format detection error apart
from format type error.
- assert_efi_firmware_content(): drop the 10 second timeout of the
format check, like assert_iso_content(), whose qemu-img call it
mirrors.
qemu-server:
- config: define bios schema as property-string
- Use v5.36 and subroutine signatures in the new BIOS module.
- Move the 'seabios' default from the bios option into its 'type'
sub-property.
- Import get_bios_type() in QemuConfig.
- bios: add a custom firmware sub-property
- check_bios() takes the property-string and parses it itself.
- Die when printing 'bios' as a volume, instead of printing it.
- Skip the custom firmware image explicitly for replication.
- Do not deactivate the custom firmware image when the VM stops (via a
new flag for get_vm_volumes()) or fails to start.
- Include the custom firmware image in the storage availability checks
for migration and cloning, like ISO images.
- Mention the volume ID in the migration error for a local custom
firmware image.
- Reword the error for remote migration with a custom firmware image.
- api: check the custom firmware of the bios option
- Use a lexical sub for check_bios_param().
- Avoid the multiline post-if in $check_storage_access.
- test: custom firmware in the bios option
- Adapt to the cfg2cmd test mocks, which moved to
QemuServerTest::CommandLineMocks.
- test: custom firmware volumes in replication and migration
- Adapt to the reworded migration error.
pve-manager:
- ui: migrate: refuse migration with a local custom firmware image
- Do not count the custom firmware image as a VM volume when the
target storages are filtered by volume type.
pve-docs:
- No changes.
Thanks Fiona Ebner for reviewing the low-level changes.
More tests and feedback are welcome. In particular for the GUI changes.
- Christian
[1] https://lore.proxmox.com/pve-devel/cover.1793029144.git@genua.de/
[2] https://lore.proxmox.com/pve-devel/cover.1790337423.git@genua.de/
[3] https://lore.proxmox.com/pve-devel/20260817115919.abQyMsVBJeHupthBjG6HbiJWe2o8RfIy9CmAttembto@z/
next reply other threads:[~2026-11-19 14:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 14:14 Christian Ludwig [this message]
2026-11-19 14:14 ` [PATCH pve-storage v4 01/20] plugin: add efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 02/20] test: get_subdir: cover the " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 03/20] plugins: allow the efi-firmware content type on file based storages Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 04/20] plugin: allow overriding the efi-firmware directory Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 05/20] plugin: support efi-firmware volumes in volume export and import Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 06/20] api: status: support efi-firmware in upload and download-url Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 07/20] test: volume access: cover efi-firmware volumes Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 08/20] test: list volumes: " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 09/20] test: cover efi-firmware volumes in parse_volname and path_to_volume_id Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 10/20] config: define bios schema as property-string Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 11/20] bios: add a custom firmware sub-property Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 12/20] api: check the custom firmware of the bios option Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 13/20] test: custom firmware in " Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 14/20] test: custom firmware volumes in replication and migration Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 15/20] ui: storage: add efi-firmware content type support Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 16/20] ui: form: support other content types in the ISO selector Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 17/20] ui: qemu: allow selecting a custom EFI firmware image Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 18/20] ui: migrate: refuse migration with a local custom " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 19/20] pvesm: document the efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 20/20] qm: document the custom firmware of the bios option Christian Ludwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1795092172.git.christian_ludwig@genua.de \
--to=christian_ludwig@genua.de \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox