public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ludwig <christian_ludwig@genua.de>
To: <pve-devel@lists.proxmox.com>
Subject: [PATCH pve-manager v4 15/20] ui: storage: add efi-firmware content type support
Date: Thu, 19 Nov 2026 15:14:27 +0100	[thread overview]
Message-ID: <037b13c8d61ce9dec69530acf9d697b12ed402dc.1795092172.git.christian_ludwig@genua.de> (raw)
In-Reply-To: <cover.1795092172.git.christian_ludwig@genua.de>

Add the 'efi-firmware' storage content type to the Web UI:

- Utils.js: add display name for the content type
- ContentTypeSelector: include in the default content type list
- CephFSEdit: include in its explicit content type list, the backend
  CephFS plugin allows the type as well
- Browser: add a tab for browsing and uploading firmware images; the
  format is always 'raw' for this type, so drop that column
- UploadToStorage: only accept files with the '.fd' extension, like the
  backend does

Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
---
 www/manager6/Utils.js                    |  1 +
 www/manager6/form/ContentTypeSelector.js | 11 ++++++++++-
 www/manager6/storage/Browser.js          | 14 ++++++++++++++
 www/manager6/storage/CephFSEdit.js       |  2 +-
 www/manager6/window/UploadToStorage.js   |  1 +
 5 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index c616ab9b..feca7e29 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -761,6 +761,7 @@ Ext.define('PVE.Utils', {
             rootdir: gettext('Container'),
             snippets: gettext('Snippets'),
             import: gettext('Import'),
+            'efi-firmware': gettext('EFI Firmware'),
             'vm-vol': gettext('VM Disk'),
             'vm-state': gettext('VM State'),
             'ct-vol': gettext('Container Volume'),
diff --git a/www/manager6/form/ContentTypeSelector.js b/www/manager6/form/ContentTypeSelector.js
index 874bb3b6..2fb2c220 100644
--- a/www/manager6/form/ContentTypeSelector.js
+++ b/www/manager6/form/ContentTypeSelector.js
@@ -80,7 +80,16 @@ Ext.define('PVE.form.ContentTypeSelector', {
         var me = this;
 
         if (me.cts === undefined) {
-            me.cts = ['images', 'iso', 'vztmpl', 'backup', 'rootdir', 'snippets', 'import'];
+            me.cts = [
+                'images',
+                'iso',
+                'vztmpl',
+                'backup',
+                'rootdir',
+                'snippets',
+                'import',
+                'efi-firmware',
+            ];
         }
 
         me.comboItems = me.comboItemsFor(me.showVolumeTypes || me.usesVolumeType(me.value));
diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index b4c20992..37e593d0 100644
--- a/www/manager6/storage/Browser.js
+++ b/www/manager6/storage/Browser.js
@@ -189,6 +189,20 @@ Ext.define('PVE.storage.Browser', {
                     pluginType: plugin,
                 });
             }
+            if (contents.includes('efi-firmware')) {
+                me.items.push({
+                    xtype: 'pveStorageContentView',
+                    title: gettext('EFI Firmware'),
+                    iconCls: 'fa fa-microchip',
+                    itemId: 'contentEfiFirmware',
+                    content: 'efi-firmware',
+                    showColumns: ['name', 'date', 'size'],
+                    pluginType: plugin,
+                    enableUploadButton: enableUpload,
+                    enableDownloadUrlButton: enableDownloadUrl,
+                    useUploadButton: true,
+                });
+            }
         }
 
         if (caps.storage['Permissions.Modify']) {
diff --git a/www/manager6/storage/CephFSEdit.js b/www/manager6/storage/CephFSEdit.js
index db54df87..3b7a49f3 100644
--- a/www/manager6/storage/CephFSEdit.js
+++ b/www/manager6/storage/CephFSEdit.js
@@ -95,7 +95,7 @@ Ext.define('PVE.storage.CephFSInputPanel', {
         me.column2 = [
             {
                 xtype: 'pveContentTypeSelector',
-                cts: ['backup', 'iso', 'vztmpl', 'snippets', 'import'],
+                cts: ['backup', 'iso', 'vztmpl', 'snippets', 'import', 'efi-firmware'],
                 fieldLabel: gettext('Content'),
                 name: 'content',
                 value: 'backup',
diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js
index a5fa1773..5b75555d 100644
--- a/www/manager6/window/UploadToStorage.js
+++ b/www/manager6/window/UploadToStorage.js
@@ -12,6 +12,7 @@ Ext.define('PVE.window.UploadToStorage', {
         import: ['.ova', '.qcow2', '.raw', '.vmdk'],
         iso: ['.img', '.iso'],
         vztmpl: ['.tar.gz', '.tar.xz', '.tar.zst'],
+        'efi-firmware': ['.fd'],
     },
 
     // accepted for file selection, but the extension does not tell the image format, so the user
-- 
2.34.1




  parent reply	other threads:[~2026-11-19 14:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 14:14 [PATCH v4 00/20] Support for custom EFI firmware Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 01/20] plugin: add efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 02/20] test: get_subdir: cover the " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 03/20] plugins: allow the efi-firmware content type on file based storages Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 04/20] plugin: allow overriding the efi-firmware directory Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 05/20] plugin: support efi-firmware volumes in volume export and import Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 06/20] api: status: support efi-firmware in upload and download-url Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 07/20] test: volume access: cover efi-firmware volumes Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 08/20] test: list volumes: " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 09/20] test: cover efi-firmware volumes in parse_volname and path_to_volume_id Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 10/20] config: define bios schema as property-string Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 11/20] bios: add a custom firmware sub-property Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 12/20] api: check the custom firmware of the bios option Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 13/20] test: custom firmware in " Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 14/20] test: custom firmware volumes in replication and migration Christian Ludwig
2026-11-19 14:14 ` Christian Ludwig [this message]
2026-11-19 14:14 ` [PATCH pve-manager v4 16/20] ui: form: support other content types in the ISO selector Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 17/20] ui: qemu: allow selecting a custom EFI firmware image Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 18/20] ui: migrate: refuse migration with a local custom " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 19/20] pvesm: document the efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 20/20] qm: document the custom firmware of the bios option Christian Ludwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=037b13c8d61ce9dec69530acf9d697b12ed402dc.1795092172.git.christian_ludwig@genua.de \
    --to=christian_ludwig@genua.de \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal