[PATCH v3 storage 20/76] pvesm: expose the SAN LUN inventory

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

From: Dietmar Maurer <dietmar@proxmox.com>

Make SAN device identities, usage and storage attribution available
from the command line so administrators can inspect candidates before
setting up shared LVM.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
[TL: print a concise column set]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 src/PVE/CLI/pvesm.pm          | 12 ++++++++++++
 src/test/run_san_api_tests.pl | 22 ++++++++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/src/PVE/CLI/pvesm.pm b/src/PVE/CLI/pvesm.pm
index 1eb83331..501b7b61 100755
--- a/src/PVE/CLI/pvesm.pm
+++ b/src/PVE/CLI/pvesm.pm
@@ -736,6 +736,18 @@ our $cmddef = {
             $print_api_result,
             $PVE::RESTHandler::standard_output_options,
         ],
+        'san-luns' => [
+            "PVE::API2::Storage::Scan",
+            'sanlunscan',
+            [],
+            { node => $nodename },
+            sub {
+                my ($data, $schema, $options) = @_;
+                my $columns = [qw(devpath size transport usage vgname used-by-storage)];
+                PVE::CLIFormatter::print_api_result($data, $schema, $columns, $options);
+            },
+            $PVE::RESTHandler::standard_output_options,
+        ],
         zfs => [
             "PVE::API2::Storage::Scan",
             'zfsscan',
diff --git a/src/test/run_san_api_tests.pl b/src/test/run_san_api_tests.pl
index 1490e3c2..de35217f 100755
--- a/src/test/run_san_api_tests.pl
+++ b/src/test/run_san_api_tests.pl
@@ -28,6 +28,28 @@ subtest 'node SAN read permissions' => sub {
     }
 };
 
+subtest 'SAN CLI columns leave machine output complete' => sub {
+    require PVE::CLI::pvesm;
+    my $formatter = Test::MockModule->new('PVE::CLIFormatter');
+    my $data = [{ devpath => '/dev/sda', serial => 'S1' }];
+    my $schema = PVE::API2::Storage::Scan->map_method_by_name('sanlunscan')->{returns};
+    $formatter->mock(
+        print_api_result => sub {
+            is($_[0], $data, 'complete records forwarded');
+            is($_[1], $schema, 'complete schema forwarded');
+            is_deeply(
+                $_[2],
+                [qw(devpath size transport usage vgname used-by-storage)],
+                'concise text columns',
+            );
+            is($_[3]->{'output-format'}, 'json', 'format option unchanged');
+        },
+    );
+    $PVE::CLI::pvesm::cmddef->{scan}->{'san-luns'}->[4]
+        ->($data, $schema, { 'output-format' => 'json' });
+    is($schema->{items}->{properties}->{size}->{renderer}, 'bytes', 'size renderer');
+};
+
 subtest 'SAN LUN path counts' => sub {
     my $disk = Test::MockModule->new('PVE::Diskmanage');
     my $lvm = Test::MockModule->new('PVE::Storage::LVMPlugin');
-- 
2.47.3