[PATCH v3 manager 55/76] ui: storage wizard: add ZFS over iSCSI support

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

From: Dietmar Maurer <dietmar@proxmox.com>

There is no scan API for this SSH-based storage type, so the wizard
splits the existing single dialog into an appliance connection step,
showing only the fields relevant for the selected iSCSI provider, and
a volume settings step.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
[TL: show the write cache positively and only for the providers that
 have the option; name the SSH key the appliance is managed with]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 www/manager6/Makefile                       |   1 +
 www/manager6/storage/wizard/ZFSOverISCSI.js | 180 ++++++++++++++++++++
 2 files changed, 181 insertions(+)
 create mode 100644 www/manager6/storage/wizard/ZFSOverISCSI.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 602e3b9b9..b60cfa569 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -385,6 +385,7 @@ JSSRC= 							\
 	storage/wizard/NFS.js				\
 	storage/wizard/CIFS.js				\
 	storage/wizard/FibreChannel.js			\
+	storage/wizard/ZFSOverISCSI.js			\
 	Workspace.js					\
 # end of JSSRC list
 
diff --git a/www/manager6/storage/wizard/ZFSOverISCSI.js b/www/manager6/storage/wizard/ZFSOverISCSI.js
new file mode 100644
index 000000000..c891aa7ea
--- /dev/null
+++ b/www/manager6/storage/wizard/ZFSOverISCSI.js
@@ -0,0 +1,180 @@
+Ext.define('PVE.storage.wizard.ZFSOverISCSIAppliance', {
+    extend: 'Proxmox.panel.InputPanel',
+    xtype: 'pveStorageWizardZFSOverISCSIAppliance',
+
+    onlineHelp: 'storage_zfs',
+
+    column1: [
+        {
+            xtype: 'pveiScsiProviderSelector',
+            name: 'iscsiprovider',
+            value: 'comstar',
+            fieldLabel: gettext('iSCSI Provider'),
+            allowBlank: false,
+            listeners: {
+                change: function (f, value) {
+                    let vm = this.up('window').getViewModel();
+                    vm.set('isLIO', value === 'LIO');
+                    vm.set('isComstar', value === 'comstar');
+                    vm.set('hasWriteCacheOption', value === 'comstar' || value === 'istgt');
+                },
+            },
+        },
+        {
+            xtype: 'textfield',
+            name: 'portal',
+            fieldLabel: gettext('Portal'),
+            allowBlank: false,
+            bind: { value: '{portal}' },
+        },
+        {
+            xtype: 'textfield',
+            name: 'target',
+            fieldLabel: gettext('Target'),
+            allowBlank: false,
+        },
+    ],
+
+    column2: [
+        {
+            xtype: 'textfield',
+            name: 'comstar_tg',
+            fieldLabel: gettext('Target group'),
+            allowBlank: true,
+            bind: {
+                disabled: '{!isComstar}',
+                hidden: '{!isComstar}',
+            },
+        },
+        {
+            xtype: 'textfield',
+            name: 'comstar_hg',
+            fieldLabel: gettext('Host group'),
+            allowBlank: true,
+            bind: {
+                disabled: '{!isComstar}',
+                hidden: '{!isComstar}',
+            },
+        },
+        {
+            xtype: 'textfield',
+            name: 'lio_tpg',
+            fieldLabel: gettext('Target portal group'),
+            allowBlank: false,
+            disabled: true,
+            hidden: true,
+            bind: {
+                disabled: '{!isLIO}',
+                hidden: '{!isLIO}',
+            },
+        },
+    ],
+
+    columnB: [
+        {
+            xtype: 'displayfield',
+            bind: { value: '{sshKeyText}' },
+        },
+    ],
+});
+
+Ext.define('PVE.storage.wizard.ZFSOverISCSIVolume', {
+    extend: 'Proxmox.panel.InputPanel',
+    xtype: 'pveStorageWizardZFSOverISCSIVolume',
+
+    onlineHelp: 'storage_zfs',
+
+    onGetValues: function (values) {
+        values.nowritecache = values.writecache ? 0 : 1;
+        delete values.writecache;
+        return values;
+    },
+
+    column1: [
+        {
+            xtype: 'textfield',
+            name: 'pool',
+            fieldLabel: gettext('Pool'),
+            allowBlank: false,
+        },
+        {
+            xtype: 'textfield',
+            name: 'blocksize',
+            value: '4k',
+            fieldLabel: gettext('Block Size'),
+            allowBlank: false,
+            validator: PVE.Utils.validateZfsBlocksize,
+        },
+    ],
+
+    column2: [
+        {
+            xtype: 'proxmoxcheckbox',
+            name: 'sparse',
+            checked: false,
+            uncheckedValue: 0,
+            fieldLabel: gettext('Thin provision'),
+        },
+        {
+            xtype: 'proxmoxcheckbox',
+            name: 'writecache',
+            checked: true,
+            uncheckedValue: 0,
+            fieldLabel: gettext('Write cache'),
+            bind: {
+                disabled: '{!hasWriteCacheOption}',
+                hidden: '{!hasWriteCacheOption}',
+            },
+        },
+    ],
+});
+
+PVE.storage.wizard.types['zfs-over-iscsi'] = {
+    text: gettext('ZFS over iSCSI'),
+    description: gettext(
+        'ZFS storage appliance managed over SSH, exporting volumes via iSCSI with snapshot support.',
+    ),
+    group: 'san',
+    apiType: 'zfs',
+    viewModel: {
+        data: {
+            isLIO: false,
+            isComstar: true,
+            hasWriteCacheOption: true,
+            portal: '',
+        },
+        formulas: {
+            sshKeyText: (get) =>
+                Ext.htmlEncode(
+                    Ext.String.format(
+                        gettext(
+                            'The appliance is managed as root over SSH. The private key must be stored in {0}, and the appliance must accept its public key.',
+                        ),
+                        `/etc/pve/priv/zfs/${get('portal') || '<portal>'}_id_rsa`,
+                    ),
+                ),
+        },
+    },
+    steps: () => [
+        {
+            xtype: 'pveStorageWizardZFSOverISCSIAppliance',
+            title: gettext('Appliance'),
+        },
+        {
+            xtype: 'pveStorageWizardZFSOverISCSIVolume',
+            title: gettext('Volume Settings'),
+        },
+    ],
+    settings: {
+        onlineHelp: 'storage_zfs',
+        fixedContent: 'images',
+    },
+    summaryFields: {
+        nowritecache: {
+            label: gettext('Write cache'),
+            isBoolean: true,
+            invert: true,
+            skip: (values) => !['comstar', 'istgt'].includes(values.iscsiprovider),
+        },
+    },
+};
-- 
2.47.3