From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C03431FF0AF for ; Fri, 06 Nov 2026 01:51:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1FACA21757; Fri, 06 Nov 2026 01:50:58 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v3 storage 20/76] pvesm: expose the SAN LUN inventory Date: Fri, 6 Nov 2026 00:30:55 +0100 Message-ID: <20261105233336.2178064-21-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261105233336.2178064-1-t.lamprecht@proxmox.com> References: <20261105233336.2178064-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793926178580 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.336 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XA3LS42WSCBYYMLGWGZWZ4CAU3Y2C3ZC X-Message-ID-Hash: XA3LS42WSCBYYMLGWGZWZ4CAU3Y2C3ZC X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Dietmar Maurer Make SAN device identities, usage and storage attribution available from the command line so administrators can inspect candidates before setting up shared LVM. Signed-off-by: Dietmar Maurer [TL: print a concise column set] Signed-off-by: Thomas Lamprecht --- src/PVE/CLI/pvesm.pm | 12 ++++++++++++ src/test/run_san_api_tests.pl | 22 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/src/PVE/CLI/pvesm.pm b/src/PVE/CLI/pvesm.pm index 1eb83331..501b7b61 100755 --- a/src/PVE/CLI/pvesm.pm +++ b/src/PVE/CLI/pvesm.pm @@ -736,6 +736,18 @@ our $cmddef = { $print_api_result, $PVE::RESTHandler::standard_output_options, ], + 'san-luns' => [ + "PVE::API2::Storage::Scan", + 'sanlunscan', + [], + { node => $nodename }, + sub { + my ($data, $schema, $options) = @_; + my $columns = [qw(devpath size transport usage vgname used-by-storage)]; + PVE::CLIFormatter::print_api_result($data, $schema, $columns, $options); + }, + $PVE::RESTHandler::standard_output_options, + ], zfs => [ "PVE::API2::Storage::Scan", 'zfsscan', diff --git a/src/test/run_san_api_tests.pl b/src/test/run_san_api_tests.pl index 1490e3c2..de35217f 100755 --- a/src/test/run_san_api_tests.pl +++ b/src/test/run_san_api_tests.pl @@ -28,6 +28,28 @@ subtest 'node SAN read permissions' => sub { } }; +subtest 'SAN CLI columns leave machine output complete' => sub { + require PVE::CLI::pvesm; + my $formatter = Test::MockModule->new('PVE::CLIFormatter'); + my $data = [{ devpath => '/dev/sda', serial => 'S1' }]; + my $schema = PVE::API2::Storage::Scan->map_method_by_name('sanlunscan')->{returns}; + $formatter->mock( + print_api_result => sub { + is($_[0], $data, 'complete records forwarded'); + is($_[1], $schema, 'complete schema forwarded'); + is_deeply( + $_[2], + [qw(devpath size transport usage vgname used-by-storage)], + 'concise text columns', + ); + is($_[3]->{'output-format'}, 'json', 'format option unchanged'); + }, + ); + $PVE::CLI::pvesm::cmddef->{scan}->{'san-luns'}->[4] + ->($data, $schema, { 'output-format' => 'json' }); + is($schema->{items}->{properties}->{size}->{renderer}, 'bytes', 'size renderer'); +}; + subtest 'SAN LUN path counts' => sub { my $disk = Test::MockModule->new('PVE::Diskmanage'); my $lvm = Test::MockModule->new('PVE::Storage::LVMPlugin'); -- 2.47.3