public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH widget-toolkit] fix #6943: ui: network selector: show comments of IPv6 entries
@ 2026-09-29 14:07 Michal Fox
  2026-09-30 12:42 ` applied: " Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Fox @ 2026-09-29 14:07 UTC (permalink / raw)
  To: pve-devel

When an interface has an IPv6 address, the selector adds a separate
entry for it and takes the comment from the 'comments6' property.
The API never returns that property: since pve-common commit f2ac9dd
("fix #3153: INotify: adding comment of interface to inet6 section when
this is the only section") the parser merges the inet6 comments into
'comments'.

As a result, the comment of IPv6-only interfaces was dropped, and the
IPv6 entry of dual-stack interfaces had no comment at all, for example
when selecting corosync links or the Ceph networks.

Just keep the 'comments' value, which is already present on the record
or on its copy.

Signed-off-by: Michal Fox <me@dualfroz.com>
---
 src/form/NetworkSelector.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/form/NetworkSelector.js b/src/form/NetworkSelector.js
index fe7c96b..fc4f70e 100644
--- a/src/form/NetworkSelector.js
+++ b/src/form/NetworkSelector.js
@@ -82,8 +82,6 @@ Ext.define('Proxmox.form.NetworkSelector', {
                             dest.data.cidr = record.data.cidr6;
                             dest.data.address = record.data.address6;
                             delete record.data.cidr6;
-                            dest.data.comments = record.data.comments6;
-                            delete record.data.comments6;
                             store.add(dest);
                         }
                     });
-- 
2.43.0




^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-30 12:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-29 14:07 [PATCH widget-toolkit] fix #6943: ui: network selector: show comments of IPv6 entries Michal Fox
2026-09-30 12:42 ` applied: " Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal