From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E01EB1FF0A7 for ; Wed, 30 Sep 2026 09:47:40 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5C3BF21753; Wed, 30 Sep 2026 09:46:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dualfroz.com; s=dkim; t=1790690832; h=from:subject:date:message-id:to:mime-version: content-transfer-encoding; bh=qd4R6eJScJ+FHXjpVuDxqNAFZyir4Avo8cZ8k1mIjko=; b=7IpkWciT4Xkct6KvdXTA/iTtFSRRUd88uI8X4ExVVuRaayGonoJax8ZPhKc+7cbV18ftFK 0VJDDo8gqI1/5uG61lozUvTMVXiLQxnax4B0GufsSyqU9CsP4u9CYGPQ6U5/l/V/VqUCkd FJ0Jio4klfAt/eH2T3trIjKZJmA5CSkxyM0b+BimaASIILUijBgK/t6rWo2oUy4TNI3gwG nR0PdnnPjkhtitVCuDfk6hYjuIchYjRyO3z6TgOgOTmsIRZQIvQk37VLDE/T+97UXUbWXe VNK0skDGHrvIhcfLgLCN6i4IdLfU8v4T2Tn1eD6TBRAWSBFQgs8opE8UkhfoQA== From: Michal Fox To: pve-devel@lists.proxmox.com Subject: [PATCH widget-toolkit] fix #6943: ui: network selector: show comments of IPv6 entries Date: Tue, 29 Sep 2026 16:07:10 +0200 Message-ID: <20260929140710.2823699-1-me@dualfroz.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address DKIM_INVALID 0.1 DKIM or DK signature exists, but is not valid DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DMARC_PASS -0.1 DMARC pass policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: me@dualfroz.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: FFQYRN7YBCOEQVSY77YWBZX3MAVEYM4G X-Message-ID-Hash: FFQYRN7YBCOEQVSY77YWBZX3MAVEYM4G X-Mailman-Approved-At: Wed, 30 Sep 2026 09:46:15 +0200 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When an interface has an IPv6 address, the selector adds a separate entry for it and takes the comment from the 'comments6' property. The API never returns that property: since pve-common commit f2ac9dd ("fix #3153: INotify: adding comment of interface to inet6 section when this is the only section") the parser merges the inet6 comments into 'comments'. As a result, the comment of IPv6-only interfaces was dropped, and the IPv6 entry of dual-stack interfaces had no comment at all, for example when selecting corosync links or the Ceph networks. Just keep the 'comments' value, which is already present on the record or on its copy. Signed-off-by: Michal Fox --- src/form/NetworkSelector.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/form/NetworkSelector.js b/src/form/NetworkSelector.js index fe7c96b..fc4f70e 100644 --- a/src/form/NetworkSelector.js +++ b/src/form/NetworkSelector.js @@ -82,8 +82,6 @@ Ext.define('Proxmox.form.NetworkSelector', { dest.data.cidr = record.data.cidr6; dest.data.address = record.data.address6; delete record.data.cidr6; - dest.data.comments = record.data.comments6; - delete record.data.comments6; store.add(dest); } }); -- 2.43.0