From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DD7BE1FF0C0 for ; Wed, 30 Sep 2026 14:42:44 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B186221619; Wed, 30 Sep 2026 14:42:41 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com, Michal Fox Subject: applied: [PATCH widget-toolkit] fix #6943: ui: network selector: show comments of IPv6 entries Date: Wed, 30 Sep 2026 14:42:27 +0200 Message-ID: <179077213738.2689478.12317165627230355505.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260929140710.2823699-1-me@dualfroz.com> References: <20260929140710.2823699-1-me@dualfroz.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.421 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NQ2VX7JRSV5L2HPWUOEVVYSY7JKIY6SX X-Message-ID-Hash: NQ2VX7JRSV5L2HPWUOEVVYSY7JKIY6SX X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 29 Sep 2026 16:07:10 +0200, Michal Fox wrote: > When an interface has an IPv6 address, the selector adds a separate > entry for it and takes the comment from the 'comments6' property. > The API never returns that property: since pve-common commit f2ac9dd > ("fix #3153: INotify: adding comment of interface to inet6 section when > this is the only section") the parser merges the inet6 comments into > 'comments'. > > [...] Applied, thanks! [1/1] fix #6943: ui: network selector: show comments of IPv6 entries commit: b92a9ad19f18065576e02ad0056c5ba5650bcf07