public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Michal Fox <me@dualfroz.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH widget-toolkit] fix #6943: ui: network selector: show comments of IPv6 entries
Date: Tue, 29 Sep 2026 16:07:10 +0200	[thread overview]
Message-ID: <20260929140710.2823699-1-me@dualfroz.com> (raw)

When an interface has an IPv6 address, the selector adds a separate
entry for it and takes the comment from the 'comments6' property.
The API never returns that property: since pve-common commit f2ac9dd
("fix #3153: INotify: adding comment of interface to inet6 section when
this is the only section") the parser merges the inet6 comments into
'comments'.

As a result, the comment of IPv6-only interfaces was dropped, and the
IPv6 entry of dual-stack interfaces had no comment at all, for example
when selecting corosync links or the Ceph networks.

Just keep the 'comments' value, which is already present on the record
or on its copy.

Signed-off-by: Michal Fox <me@dualfroz.com>
---
 src/form/NetworkSelector.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/form/NetworkSelector.js b/src/form/NetworkSelector.js
index fe7c96b..fc4f70e 100644
--- a/src/form/NetworkSelector.js
+++ b/src/form/NetworkSelector.js
@@ -82,8 +82,6 @@ Ext.define('Proxmox.form.NetworkSelector', {
                             dest.data.cidr = record.data.cidr6;
                             dest.data.address = record.data.address6;
                             delete record.data.cidr6;
-                            dest.data.comments = record.data.comments6;
-                            delete record.data.comments6;
                             store.add(dest);
                         }
                     });
-- 
2.43.0




             reply	other threads:[~2026-09-30  7:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 14:07 Michal Fox [this message]
2026-09-30 12:42 ` applied: [PATCH widget-toolkit] fix #6943: ui: network selector: show comments of IPv6 entries Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929140710.2823699-1-me@dualfroz.com \
    --to=me@dualfroz.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal