* [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
@ 2026-05-07 6:55 Arthur Bied-Charreton
2026-05-07 7:05 ` Dominik Csapak
2026-05-07 9:28 ` applied: " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Arthur Bied-Charreton @ 2026-05-07 6:55 UTC (permalink / raw)
To: pve-devel; +Cc: d.riley
Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a
new OSPanel component, but left the onGetValues hook that appends the
`media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer
appears.
As a result, creating a Windows guest with the "Add additional drive for
VirtIO drivers" checkbox enabled fails due to the missing explicit
media=cdrom.
Move the now-unreachable onGetValues logic from OSTypeInputPanel onto
the wrapper inputpanel that now actually holds the ISO selector in
OSPanel.
Reported-by: David Riley <d.riley@proxmox.com>
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
www/manager6/qemu/OSPanel.js | 10 ++++++++++
www/manager6/qemu/OSTypeEdit.js | 11 -----------
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js
index be0e5b85..556ad4c3 100644
--- a/www/manager6/qemu/OSPanel.js
+++ b/www/manager6/qemu/OSPanel.js
@@ -130,6 +130,16 @@ Ext.define('PVE.qemu.OSPanel', {
},
{
xtype: 'inputpanel',
+ onGetValues: function (values) {
+ if (values.ide0) {
+ let drive = {
+ media: 'cdrom',
+ file: values.ide0,
+ };
+ values.ide0 = PVE.Parser.printQemuDrive(drive);
+ }
+ return values;
+ },
items: [
{
xtype: 'proxmoxcheckbox',
diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
index 5c79164f..5a2f2ae6 100644
--- a/www/manager6/qemu/OSTypeEdit.js
+++ b/www/manager6/qemu/OSTypeEdit.js
@@ -36,17 +36,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
}
},
- onGetValues: function (values) {
- if (values.ide0) {
- let drive = {
- media: 'cdrom',
- file: values.ide0,
- };
- values.ide0 = PVE.Parser.printQemuDrive(drive);
- }
- return values;
- },
-
initComponent: function () {
var me = this;
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
2026-05-07 6:55 [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO Arthur Bied-Charreton
@ 2026-05-07 7:05 ` Dominik Csapak
2026-05-07 7:20 ` David Riley
2026-05-07 9:28 ` applied: " Thomas Lamprecht
1 sibling, 1 reply; 4+ messages in thread
From: Dominik Csapak @ 2026-05-07 7:05 UTC (permalink / raw)
To: Arthur Bied-Charreton, pve-devel; +Cc: d.riley
yep, I overlooked this, patch works
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
On 5/7/26 8:53 AM, Arthur Bied-Charreton wrote:
> Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a
> new OSPanel component, but left the onGetValues hook that appends the
> `media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer
> appears.
>
> As a result, creating a Windows guest with the "Add additional drive for
> VirtIO drivers" checkbox enabled fails due to the missing explicit
> media=cdrom.
>
> Move the now-unreachable onGetValues logic from OSTypeInputPanel onto
> the wrapper inputpanel that now actually holds the ISO selector in
> OSPanel.
>
> Reported-by: David Riley <d.riley@proxmox.com>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
> www/manager6/qemu/OSPanel.js | 10 ++++++++++
> www/manager6/qemu/OSTypeEdit.js | 11 -----------
> 2 files changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js
> index be0e5b85..556ad4c3 100644
> --- a/www/manager6/qemu/OSPanel.js
> +++ b/www/manager6/qemu/OSPanel.js
> @@ -130,6 +130,16 @@ Ext.define('PVE.qemu.OSPanel', {
> },
> {
> xtype: 'inputpanel',
> + onGetValues: function (values) {
> + if (values.ide0) {
> + let drive = {
> + media: 'cdrom',
> + file: values.ide0,
> + };
> + values.ide0 = PVE.Parser.printQemuDrive(drive);
> + }
> + return values;
> + },
> items: [
> {
> xtype: 'proxmoxcheckbox',
> diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
> index 5c79164f..5a2f2ae6 100644
> --- a/www/manager6/qemu/OSTypeEdit.js
> +++ b/www/manager6/qemu/OSTypeEdit.js
> @@ -36,17 +36,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
> }
> },
>
> - onGetValues: function (values) {
> - if (values.ide0) {
> - let drive = {
> - media: 'cdrom',
> - file: values.ide0,
> - };
> - values.ide0 = PVE.Parser.printQemuDrive(drive);
> - }
> - return values;
> - },
> -
> initComponent: function () {
> var me = this;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
2026-05-07 7:05 ` Dominik Csapak
@ 2026-05-07 7:20 ` David Riley
0 siblings, 0 replies; 4+ messages in thread
From: David Riley @ 2026-05-07 7:20 UTC (permalink / raw)
To: Dominik Csapak, Arthur Bied-Charreton, pve-devel
Thanks for looking into it.
Checked out this patch and it successfully restores the original
behavior.
On 5/7/26 9:04 AM, Dominik Csapak wrote:
> yep, I overlooked this, patch works
>
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
>
> On 5/7/26 8:53 AM, Arthur Bied-Charreton wrote:
>> Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a
>> new OSPanel component, but left the onGetValues hook that appends the
>> `media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer
>> appears.
>>
>> As a result, creating a Windows guest with the "Add additional drive for
>> VirtIO drivers" checkbox enabled fails due to the missing explicit
>> media=cdrom.
>>
>> Move the now-unreachable onGetValues logic from OSTypeInputPanel onto
>> the wrapper inputpanel that now actually holds the ISO selector in
>> OSPanel.
>>
>> Reported-by: David Riley <d.riley@proxmox.com>
>> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
>> ---
>> www/manager6/qemu/OSPanel.js | 10 ++++++++++
>> www/manager6/qemu/OSTypeEdit.js | 11 -----------
>> 2 files changed, 10 insertions(+), 11 deletions(-)
>>
>> diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js
>> index be0e5b85..556ad4c3 100644
>> --- a/www/manager6/qemu/OSPanel.js
>> +++ b/www/manager6/qemu/OSPanel.js
>> @@ -130,6 +130,16 @@ Ext.define('PVE.qemu.OSPanel', {
>> },
>> {
>> xtype: 'inputpanel',
>> + onGetValues: function (values) {
>> + if (values.ide0) {
>> + let drive = {
>> + media: 'cdrom',
>> + file: values.ide0,
>> + };
>> + values.ide0 = PVE.Parser.printQemuDrive(drive);
>> + }
>> + return values;
>> + },
>> items: [
>> {
>> xtype: 'proxmoxcheckbox',
>> diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
>> index 5c79164f..5a2f2ae6 100644
>> --- a/www/manager6/qemu/OSTypeEdit.js
>> +++ b/www/manager6/qemu/OSTypeEdit.js
>> @@ -36,17 +36,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
>> }
>> },
>> - onGetValues: function (values) {
>> - if (values.ide0) {
>> - let drive = {
>> - media: 'cdrom',
>> - file: values.ide0,
>> - };
>> - values.ide0 = PVE.Parser.printQemuDrive(drive);
>> - }
>> - return values;
>> - },
>> -
>> initComponent: function () {
>> var me = this;
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* applied: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
2026-05-07 6:55 [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO Arthur Bied-Charreton
2026-05-07 7:05 ` Dominik Csapak
@ 2026-05-07 9:28 ` Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2026-05-07 9:28 UTC (permalink / raw)
To: pve-devel, Arthur Bied-Charreton; +Cc: d.riley
On Thu, 07 May 2026 08:55:17 +0200, Arthur Bied-Charreton wrote:
> Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a
> new OSPanel component, but left the onGetValues hook that appends the
> `media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer
> appears.
>
> As a result, creating a Windows guest with the "Add additional drive for
> VirtIO drivers" checkbox enabled fails due to the missing explicit
> media=cdrom.
>
> [...]
Applied, thanks!
[1/1] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
commit: dc12d54446047b2f4fffc9876e1bc072647cc8ff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-07 9:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-07 6:55 [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO Arthur Bied-Charreton
2026-05-07 7:05 ` Dominik Csapak
2026-05-07 7:20 ` David Riley
2026-05-07 9:28 ` applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox