Re: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO

[David Riley <d.riley@proxmox.com>]

Thanks for looking into it.
Checked out this patch and it successfully restores the original
behavior.

On 5/7/26 9:04 AM, Dominik Csapak wrote:
> yep, I overlooked this, patch works
>
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
>
> On 5/7/26 8:53 AM, Arthur Bied-Charreton wrote:
>> Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a
>> new OSPanel component, but left the onGetValues hook that appends the
>> `media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer
>> appears.
>>
>> As a result, creating a Windows guest with the "Add additional drive for
>> VirtIO drivers" checkbox enabled fails due to the missing explicit
>> media=cdrom.
>>
>> Move the now-unreachable onGetValues logic from OSTypeInputPanel onto
>> the wrapper inputpanel that now actually holds the ISO selector in
>> OSPanel.
>>
>> Reported-by: David Riley <d.riley@proxmox.com>
>> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
>> ---
>>   www/manager6/qemu/OSPanel.js    | 10 ++++++++++
>>   www/manager6/qemu/OSTypeEdit.js | 11 -----------
>>   2 files changed, 10 insertions(+), 11 deletions(-)
>>
>> diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js
>> index be0e5b85..556ad4c3 100644
>> --- a/www/manager6/qemu/OSPanel.js
>> +++ b/www/manager6/qemu/OSPanel.js
>> @@ -130,6 +130,16 @@ Ext.define('PVE.qemu.OSPanel', {
>>                   },
>>                   {
>>                       xtype: 'inputpanel',
>> +                    onGetValues: function (values) {
>> +                        if (values.ide0) {
>> +                            let drive = {
>> +                                media: 'cdrom',
>> +                                file: values.ide0,
>> +                            };
>> +                            values.ide0 = PVE.Parser.printQemuDrive(drive);
>> +                        }
>> +                        return values;
>> +                    },
>>                       items: [
>>                           {
>>                               xtype: 'proxmoxcheckbox',
>> diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
>> index 5c79164f..5a2f2ae6 100644
>> --- a/www/manager6/qemu/OSTypeEdit.js
>> +++ b/www/manager6/qemu/OSTypeEdit.js
>> @@ -36,17 +36,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
>>           }
>>       },
>>   -    onGetValues: function (values) {
>> -        if (values.ide0) {
>> -            let drive = {
>> -                media: 'cdrom',
>> -                file: values.ide0,
>> -            };
>> -            values.ide0 = PVE.Parser.printQemuDrive(drive);
>> -        }
>> -        return values;
>> -    },
>> -
>>       initComponent: function () {
>>           var me = this;
>
>
>
>
>