From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Cc: d.riley@proxmox.com
Subject: applied: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
Date: Thu, 7 May 2026 11:28:09 +0200 [thread overview]
Message-ID: <177814608251.2839738.14339648608584182467.b4-ty@b4> (raw)
In-Reply-To: <20260507065517.237996-1-a.bied-charreton@proxmox.com>
On Thu, 07 May 2026 08:55:17 +0200, Arthur Bied-Charreton wrote:
> Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a
> new OSPanel component, but left the onGetValues hook that appends the
> `media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer
> appears.
>
> As a result, creating a Windows guest with the "Add additional drive for
> VirtIO drivers" checkbox enabled fails due to the missing explicit
> media=cdrom.
>
> [...]
Applied, thanks!
[1/1] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
commit: dc12d54446047b2f4fffc9876e1bc072647cc8ff
prev parent reply other threads:[~2026-05-07 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 6:55 [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO Arthur Bied-Charreton
2026-05-07 7:05 ` Dominik Csapak
2026-05-07 7:20 ` David Riley
2026-05-07 9:28 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177814608251.2839738.14339648608584182467.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox