public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: d.riley@proxmox.com
Subject: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
Date: Thu,  7 May 2026 08:55:17 +0200	[thread overview]
Message-ID: <20260507065517.237996-1-a.bied-charreton@proxmox.com> (raw)

Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a
new OSPanel component, but left the onGetValues hook that appends the
`media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer
appears.

As a result, creating a Windows guest with the "Add additional drive for
VirtIO drivers" checkbox enabled fails due to the missing explicit
media=cdrom.

Move the now-unreachable onGetValues logic from OSTypeInputPanel onto
the wrapper inputpanel that now actually holds the ISO selector in
OSPanel.

Reported-by: David Riley <d.riley@proxmox.com>
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/qemu/OSPanel.js    | 10 ++++++++++
 www/manager6/qemu/OSTypeEdit.js | 11 -----------
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js
index be0e5b85..556ad4c3 100644
--- a/www/manager6/qemu/OSPanel.js
+++ b/www/manager6/qemu/OSPanel.js
@@ -130,6 +130,16 @@ Ext.define('PVE.qemu.OSPanel', {
                 },
                 {
                     xtype: 'inputpanel',
+                    onGetValues: function (values) {
+                        if (values.ide0) {
+                            let drive = {
+                                media: 'cdrom',
+                                file: values.ide0,
+                            };
+                            values.ide0 = PVE.Parser.printQemuDrive(drive);
+                        }
+                        return values;
+                    },
                     items: [
                         {
                             xtype: 'proxmoxcheckbox',
diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
index 5c79164f..5a2f2ae6 100644
--- a/www/manager6/qemu/OSTypeEdit.js
+++ b/www/manager6/qemu/OSTypeEdit.js
@@ -36,17 +36,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
         }
     },
 
-    onGetValues: function (values) {
-        if (values.ide0) {
-            let drive = {
-                media: 'cdrom',
-                file: values.ide0,
-            };
-            values.ide0 = PVE.Parser.printQemuDrive(drive);
-        }
-        return values;
-    },
-
     initComponent: function () {
         var me = this;
 
-- 
2.47.3




             reply	other threads:[~2026-05-07  6:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  6:55 Arthur Bied-Charreton [this message]
2026-05-07  7:05 ` [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO Dominik Csapak
2026-05-07  7:20   ` David Riley
2026-05-07  9:28 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507065517.237996-1-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal