public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Erik Fastermann <e.fastermann@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2 3/5] ui: datastore: update code formatting with biome
Date: Wed, 6 May 2026 17:11:48 +0200	[thread overview]
Message-ID: <e9b253c6-a859-41f3-813c-42c75cbbe412@proxmox.com> (raw)
In-Reply-To: <20260506121332.21896-4-e.fastermann@proxmox.com>

LGTM, but it'd probably be better to order formatting
commits upfront, so they can already be applied,
independently of the actual code changes.

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 5/6/26 2:11 PM, Erik Fastermann wrote:
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
>   www/datastore/Content.js | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index 54e93bd3c..cb0159a51 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -1147,14 +1147,18 @@ Ext.define('PBS.DataStoreContent', {
>                           return Ext.String.format(gettext("Move namespace '{0}'"), v);
>                       },
>                       getClass: (v, m, { data }) => {
> -                        if (data.ty === 'group') { return 'fa fa-arrows'; }
> +                        if (data.ty === 'group') {
> +                            return 'fa fa-arrows';
> +                        }
>                           if (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) {
>                               return 'fa fa-arrows';
>                           }
>                           return 'pmx-hidden';
>                       },
>                       isActionDisabled: (v, r, c, i, { data }) => {
> -                        if (data.ty === 'group') { return false; }
> +                        if (data.ty === 'group') {
> +                            return false;
> +                        }
>                           if (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) {
>                               return false;
>                           }





  reply	other threads:[~2026-05-06 15:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 12:13 [PATCH proxmox-backup v2 0/5] fix #6691: allow search by comment in datastore content Erik Fastermann
2026-05-06 12:13 ` [PATCH proxmox-backup v2 1/5] " Erik Fastermann
2026-05-06 14:08   ` Shan Shaji
2026-05-06 15:06   ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 2/5] ui: datastore: fix content search empty list Erik Fastermann
2026-05-06 15:10   ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 3/5] ui: datastore: update code formatting with biome Erik Fastermann
2026-05-06 15:11   ` Dominik Csapak [this message]
2026-05-06 12:13 ` [PATCH proxmox-backup v2 4/5] ui: datastore: disable remove action for namespaces Erik Fastermann
2026-05-06 15:13   ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 5/5] ui: datastore: disable browse action for root ns Erik Fastermann
2026-05-06 15:13   ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9b253c6-a859-41f3-813c-42c75cbbe412@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=e.fastermann@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal