From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C86631FF13B for ; Wed, 06 May 2026 17:12:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A8427255FE; Wed, 6 May 2026 17:12:21 +0200 (CEST) Message-ID: Date: Wed, 6 May 2026 17:11:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup v2 3/5] ui: datastore: update code formatting with biome To: Erik Fastermann , pbs-devel@lists.proxmox.com References: <20260506121332.21896-1-e.fastermann@proxmox.com> <20260506121332.21896-4-e.fastermann@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260506121332.21896-4-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778080201640 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GJTHPCBM7R6JLQO6ZRCJDUXBUUJLOENO X-Message-ID-Hash: GJTHPCBM7R6JLQO6ZRCJDUXBUUJLOENO X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: LGTM, but it'd probably be better to order formatting commits upfront, so they can already be applied, independently of the actual code changes. Reviewed-by: Dominik Csapak On 5/6/26 2:11 PM, Erik Fastermann wrote: > Signed-off-by: Erik Fastermann > --- > www/datastore/Content.js | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/www/datastore/Content.js b/www/datastore/Content.js > index 54e93bd3c..cb0159a51 100644 > --- a/www/datastore/Content.js > +++ b/www/datastore/Content.js > @@ -1147,14 +1147,18 @@ Ext.define('PBS.DataStoreContent', { > return Ext.String.format(gettext("Move namespace '{0}'"), v); > }, > getClass: (v, m, { data }) => { > - if (data.ty === 'group') { return 'fa fa-arrows'; } > + if (data.ty === 'group') { > + return 'fa fa-arrows'; > + } > if (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) { > return 'fa fa-arrows'; > } > return 'pmx-hidden'; > }, > isActionDisabled: (v, r, c, i, { data }) => { > - if (data.ty === 'group') { return false; } > + if (data.ty === 'group') { > + return false; > + } > if (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) { > return false; > }