Re: [PATCH proxmox-backup v2 1/5] fix #6691: allow search by comment in datastore content

[Dominik Csapak <d.csapak@proxmox.com>]

while the change looks good to me too,
i would like it more if the new functionality (search in comment)
and the change to the existing features (case insensitive search in
owner and text fields) would be two separate commits.

(order does not matter to me though)

On 5/6/26 2:11 PM, Erik Fastermann wrote:
> Use case-insensitive matching, also for text and owner.
> 
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
> 
>   changes since v1:
>   * use case-insensitive matching for all fields, but with toLowerCase
> 
>   www/datastore/Content.js | 16 +++++++---------
>   1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index 1ec07505d..e963d62f9 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -933,15 +933,13 @@ Ext.define('PBS.DataStoreContent', {
>           },
>   
>           filter: function (item, value) {
> -            if (item.data.text.indexOf(value) !== -1) {
> -                return true;
> -            }
> -
> -            if (item.data.owner && item.data.owner.indexOf(value) !== -1) {
> -                return true;
> -            }
> +            const needle = value.toLowerCase();
>   
> -            return false;
> +            return (
> +                item.data.text.toLowerCase().includes(needle) ||
> +                (item.data.owner && item.data.owner.toLowerCase().includes(needle)) ||
> +                (item.data.comment && item.data.comment.toLowerCase().includes(needle))
> +            );
>           },
>   
>           search: function (tf, value) {
> @@ -1486,7 +1484,7 @@ Ext.define('PBS.DataStoreContent', {
>           {
>               xtype: 'textfield',
>               reference: 'searchbox',
> -            emptyText: gettext('group, date or owner'),
> +            emptyText: gettext('group, date, owner or comment'),
>               triggers: {
>                   clear: {
>                       cls: 'pmx-clear-trigger',