From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CA4D21FF13B for ; Wed, 06 May 2026 17:06:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B72325362; Wed, 6 May 2026 17:06:47 +0200 (CEST) Message-ID: <3450dbf6-4dc2-4705-8871-2a1c11241fef@proxmox.com> Date: Wed, 6 May 2026 17:06:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup v2 1/5] fix #6691: allow search by comment in datastore content To: Erik Fastermann , pbs-devel@lists.proxmox.com References: <20260506121332.21896-1-e.fastermann@proxmox.com> <20260506121332.21896-2-e.fastermann@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260506121332.21896-2-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778079895138 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZUGINESN4C3REA6FZVFGTJ2RN6YLYFR4 X-Message-ID-Hash: ZUGINESN4C3REA6FZVFGTJ2RN6YLYFR4 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: while the change looks good to me too, i would like it more if the new functionality (search in comment) and the change to the existing features (case insensitive search in owner and text fields) would be two separate commits. (order does not matter to me though) On 5/6/26 2:11 PM, Erik Fastermann wrote: > Use case-insensitive matching, also for text and owner. > > Signed-off-by: Erik Fastermann > --- > > changes since v1: > * use case-insensitive matching for all fields, but with toLowerCase > > www/datastore/Content.js | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/www/datastore/Content.js b/www/datastore/Content.js > index 1ec07505d..e963d62f9 100644 > --- a/www/datastore/Content.js > +++ b/www/datastore/Content.js > @@ -933,15 +933,13 @@ Ext.define('PBS.DataStoreContent', { > }, > > filter: function (item, value) { > - if (item.data.text.indexOf(value) !== -1) { > - return true; > - } > - > - if (item.data.owner && item.data.owner.indexOf(value) !== -1) { > - return true; > - } > + const needle = value.toLowerCase(); > > - return false; > + return ( > + item.data.text.toLowerCase().includes(needle) || > + (item.data.owner && item.data.owner.toLowerCase().includes(needle)) || > + (item.data.comment && item.data.comment.toLowerCase().includes(needle)) > + ); > }, > > search: function (tf, value) { > @@ -1486,7 +1484,7 @@ Ext.define('PBS.DataStoreContent', { > { > xtype: 'textfield', > reference: 'searchbox', > - emptyText: gettext('group, date or owner'), > + emptyText: gettext('group, date, owner or comment'), > triggers: { > clear: { > cls: 'pmx-clear-trigger',