From: Erik Fastermann <e.fastermann@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH proxmox-backup v2 1/5] fix #6691: allow search by comment in datastore content
Date: Wed, 6 May 2026 14:13:28 +0200 [thread overview]
Message-ID: <20260506121332.21896-2-e.fastermann@proxmox.com> (raw)
In-Reply-To: <20260506121332.21896-1-e.fastermann@proxmox.com>
Use case-insensitive matching, also for text and owner.
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
changes since v1:
* use case-insensitive matching for all fields, but with toLowerCase
www/datastore/Content.js | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 1ec07505d..e963d62f9 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -933,15 +933,13 @@ Ext.define('PBS.DataStoreContent', {
},
filter: function (item, value) {
- if (item.data.text.indexOf(value) !== -1) {
- return true;
- }
-
- if (item.data.owner && item.data.owner.indexOf(value) !== -1) {
- return true;
- }
+ const needle = value.toLowerCase();
- return false;
+ return (
+ item.data.text.toLowerCase().includes(needle) ||
+ (item.data.owner && item.data.owner.toLowerCase().includes(needle)) ||
+ (item.data.comment && item.data.comment.toLowerCase().includes(needle))
+ );
},
search: function (tf, value) {
@@ -1486,7 +1484,7 @@ Ext.define('PBS.DataStoreContent', {
{
xtype: 'textfield',
reference: 'searchbox',
- emptyText: gettext('group, date or owner'),
+ emptyText: gettext('group, date, owner or comment'),
triggers: {
clear: {
cls: 'pmx-clear-trigger',
--
2.47.3
next prev parent reply other threads:[~2026-05-06 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 12:13 [PATCH proxmox-backup v2 0/5] fix #6691: allow search by comment in datastore content Erik Fastermann
2026-05-06 12:13 ` Erik Fastermann [this message]
2026-05-06 14:08 ` [PATCH proxmox-backup v2 1/5] " Shan Shaji
2026-05-06 15:06 ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 2/5] ui: datastore: fix content search empty list Erik Fastermann
2026-05-06 15:10 ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 3/5] ui: datastore: update code formatting with biome Erik Fastermann
2026-05-06 15:11 ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 4/5] ui: datastore: disable remove action for namespaces Erik Fastermann
2026-05-06 15:13 ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 5/5] ui: datastore: disable browse action for root ns Erik Fastermann
2026-05-06 15:13 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506121332.21896-2-e.fastermann@proxmox.com \
--to=e.fastermann@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox