public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Erik Fastermann <e.fastermann@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2 5/5] ui: datastore: disable browse action for root ns
Date: Wed, 6 May 2026 17:13:47 +0200	[thread overview]
Message-ID: <c5eb0595-5f9d-448b-860b-61703b16f1b9@proxmox.com> (raw)
In-Reply-To: <20260506121332.21896-6-e.fastermann@proxmox.com>



On 5/6/26 2:12 PM, Erik Fastermann wrote:
> Disable the browse action and tooltip for the root namespace.

same as the previous patch, please include a short 'why'
(the 'what' can most often be seen in the code anyway ;) )

> 
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
> 
>   changes since v1:
>   * cleaned up boolean logic
> 
>   www/datastore/Content.js | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index 576e70a59..a2047148f 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -1241,13 +1241,14 @@ Ext.define('PBS.DataStoreContent', {
>                           }
>                           return 'pmx-hidden';
>                       },
> -                    isActionDisabled: (v, r, c, i, { data }) =>
> -                        !(
> +                    isActionDisabled: (v, r, c, i, { data }) => {
> +                        const enableFile =
>                               data.ty === 'file' &&
>                               (data.filename.endsWith('.pxar.didx') ||
>                                   data.filename.endsWith('.mpxar.didx')) &&
> -                            data['crypt-mode'] < 3
> -                        ) && data.ty !== 'ns',
> +                            data['crypt-mode'] < 3;
> +                        return !enableFile && (data.ty !== 'ns' || data.root);
> +                    },
>                   },
>               ],
>           },





      reply	other threads:[~2026-05-06 15:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 12:13 [PATCH proxmox-backup v2 0/5] fix #6691: allow search by comment in datastore content Erik Fastermann
2026-05-06 12:13 ` [PATCH proxmox-backup v2 1/5] " Erik Fastermann
2026-05-06 14:08   ` Shan Shaji
2026-05-06 15:06   ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 2/5] ui: datastore: fix content search empty list Erik Fastermann
2026-05-06 15:10   ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 3/5] ui: datastore: update code formatting with biome Erik Fastermann
2026-05-06 15:11   ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 4/5] ui: datastore: disable remove action for namespaces Erik Fastermann
2026-05-06 15:13   ` Dominik Csapak
2026-05-06 12:13 ` [PATCH proxmox-backup v2 5/5] ui: datastore: disable browse action for root ns Erik Fastermann
2026-05-06 15:13   ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5eb0595-5f9d-448b-860b-61703b16f1b9@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=e.fastermann@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal