[PATCH proxmox-backup] ui: remote edit: correctly handle delete values as array

[PATCH proxmox-backup] ui: remote edit: correctly handle delete values as array

[Christian Ebner]

PBS.Utils.delete_if_default() threats delete values either as array
or as comma separated list, depending on the type passed via the
parameters. For the remote edit window an array is needed to be api
compatible, so the parameter must be handled as such, also when only
a single delete value e.g. `port` is given a-priori.

Fixes: 45db2c6e8 ("ui: expose flag to use node's http proxy in remote edit window")
Fixes: https://forum.proxmox.com/threads/183130/post-858403
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/window/RemoteEdit.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 32f38ea10..e33325e3a 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -168,6 +168,10 @@ Ext.define('PBS.window.RemoteEdit', {
             delete values.password;
         }
 
+        if (values.delete && !Ext.isArray(values.delete)) {
+            values.delete = values.delete.split(',');
+        }
+
         if (!me.isCreate) {
             PBS.Utils.delete_if_default(values, 'use-node-proxy', false);
         }
-- 
2.47.3

Re: [PATCH proxmox-backup] ui: remote edit: correctly handle delete values as array

[Dominik Csapak]

sent a patch with a different approach (more general i think):

https://lore.proxmox.com/pbs-devel/20260623112114.976670-1-d.csapak@proxmox.com/T/#

obsoleted: [PATCH proxmox-backup] ui: remote edit: correctly handle delete values as array

[Christian Ebner]

On 6/23/26 1:21 PM, Dominik Csapak wrote:
> sent a patch with a different approach (more general i think):
> 
> https://lore.proxmox.com/pbs-devel/20260623112114.976670-1- 
> d.csapak@proxmox.com/T/#

Thanks, fixing the root cause due to the lingering legacy assumptions in 
the helper is preferable indeed.

That renders the original patch obsolete.