From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup] ui: remote edit: correctly handle delete values as array
Date: Tue, 23 Jun 2026 12:05:25 +0200 [thread overview]
Message-ID: <20260623100525.69448-1-c.ebner@proxmox.com> (raw)
PBS.Utils.delete_if_default() threats delete values either as array
or as comma separated list, depending on the type passed via the
parameters. For the remote edit window an array is needed to be api
compatible, so the parameter must be handled as such, also when only
a single delete value e.g. `port` is given a-priori.
Fixes: 45db2c6e8 ("ui: expose flag to use node's http proxy in remote edit window")
Fixes: https://forum.proxmox.com/threads/183130/post-858403
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
www/window/RemoteEdit.js | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 32f38ea10..e33325e3a 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -168,6 +168,10 @@ Ext.define('PBS.window.RemoteEdit', {
delete values.password;
}
+ if (values.delete && !Ext.isArray(values.delete)) {
+ values.delete = values.delete.split(',');
+ }
+
if (!me.isCreate) {
PBS.Utils.delete_if_default(values, 'use-node-proxy', false);
}
--
2.47.3
next reply other threads:[~2026-06-23 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 10:05 Christian Ebner [this message]
2026-06-23 11:22 ` [PATCH proxmox-backup] ui: remote edit: correctly handle delete values as array Dominik Csapak
2026-06-23 11:53 ` obsoleted: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260623100525.69448-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox