From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 79FFC1FF146 for ; Tue, 23 Jun 2026 12:06:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 86B931EA4F; Tue, 23 Jun 2026 12:06:12 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] ui: remote edit: correctly handle delete values as array Date: Tue, 23 Jun 2026 12:05:25 +0200 Message-ID: <20260623100525.69448-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782209127105 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: LZRUCGERC33JEWAFGVNVPAAGX7SXEUBS X-Message-ID-Hash: LZRUCGERC33JEWAFGVNVPAAGX7SXEUBS X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: PBS.Utils.delete_if_default() threats delete values either as array or as comma separated list, depending on the type passed via the parameters. For the remote edit window an array is needed to be api compatible, so the parameter must be handled as such, also when only a single delete value e.g. `port` is given a-priori. Fixes: 45db2c6e8 ("ui: expose flag to use node's http proxy in remote edit window") Fixes: https://forum.proxmox.com/threads/183130/post-858403 Signed-off-by: Christian Ebner --- www/window/RemoteEdit.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js index 32f38ea10..e33325e3a 100644 --- a/www/window/RemoteEdit.js +++ b/www/window/RemoteEdit.js @@ -168,6 +168,10 @@ Ext.define('PBS.window.RemoteEdit', { delete values.password; } + if (values.delete && !Ext.isArray(values.delete)) { + values.delete = values.delete.split(','); + } + if (!me.isCreate) { PBS.Utils.delete_if_default(values, 'use-node-proxy', false); } -- 2.47.3