Re: [PATCH proxmox-backup v3 01/15] bin: api: early init proxmox-product-config

[Robert Obkircher <r.obkircher@proxmox.com>]

On 01.07.26 16:04, Christian Ebner wrote:
> In preparation for switching over config related helpers to the
> proxmox-product-config. These helpers rely on the priv- and api-user
> to already have been initialized.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  src/bin/proxmox-backup-api.rs | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/bin/proxmox-backup-api.rs b/src/bin/proxmox-backup-api.rs
> index e49532810..710a70042 100644
> --- a/src/bin/proxmox-backup-api.rs
> +++ b/src/bin/proxmox-backup-api.rs
> @@ -48,6 +48,9 @@ async fn run() -> Result<(), Error> {
>          .tasklog_pbs()
>          .init()?;
>  
> +    let backup_user = pbs_config::backup_user()?;
> +    proxmox_product_config::init(backup_user.clone(), pbs_config::priv_user()?);
> +
>      config::create_configdir()?;
>  
>      config::update_self_signed_cert(false)?;
> @@ -75,10 +78,8 @@ async fn run() -> Result<(), Error> {
>  
>      proxmox_backup::auth_helpers::setup_auth_context(true);
>      proxmox_backup::server::notifications::init()?;
> -    let backup_user = pbs_config::backup_user()?;
>      let mut command_sock = proxmox_daemon::command_socket::CommandSocket::new(backup_user.gid);
>  
> -    proxmox_product_config::init(backup_user.clone(), pbs_config::priv_user()?);
>      proxmox_acme_api::init(configdir!("/acme"), true)?;
>  
>      let dir_opts = CreateOptions::new()

A similar change is also needed for proxmox-backup-proxy::main because
it currently panics during metric_collection::init.

Other binaries could be affected as well, but at least the ones that
already call proxmox_product_config::init look ok to me.