From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1573E1FF150 for ; Mon, 06 Jul 2026 12:06:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4909321439; Mon, 06 Jul 2026 12:06:21 +0200 (CEST) Message-ID: Date: Mon, 6 Jul 2026 12:06:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v3 01/15] bin: api: early init proxmox-product-config To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260701140412.200920-1-c.ebner@proxmox.com> <20260701140412.200920-2-c.ebner@proxmox.com> Content-Language: en-US, de-AT From: Robert Obkircher In-Reply-To: <20260701140412.200920-2-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783332371917 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6MRLXRJMOLE2DVH6VWBDADH7ZQAHAJTX X-Message-ID-Hash: 6MRLXRJMOLE2DVH6VWBDADH7ZQAHAJTX X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 01.07.26 16:04, Christian Ebner wrote: > In preparation for switching over config related helpers to the > proxmox-product-config. These helpers rely on the priv- and api-user > to already have been initialized. > > Signed-off-by: Christian Ebner > --- > src/bin/proxmox-backup-api.rs | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/bin/proxmox-backup-api.rs b/src/bin/proxmox-backup-api.rs > index e49532810..710a70042 100644 > --- a/src/bin/proxmox-backup-api.rs > +++ b/src/bin/proxmox-backup-api.rs > @@ -48,6 +48,9 @@ async fn run() -> Result<(), Error> { > .tasklog_pbs() > .init()?; > > + let backup_user = pbs_config::backup_user()?; > + proxmox_product_config::init(backup_user.clone(), pbs_config::priv_user()?); > + > config::create_configdir()?; > > config::update_self_signed_cert(false)?; > @@ -75,10 +78,8 @@ async fn run() -> Result<(), Error> { > > proxmox_backup::auth_helpers::setup_auth_context(true); > proxmox_backup::server::notifications::init()?; > - let backup_user = pbs_config::backup_user()?; > let mut command_sock = proxmox_daemon::command_socket::CommandSocket::new(backup_user.gid); > > - proxmox_product_config::init(backup_user.clone(), pbs_config::priv_user()?); > proxmox_acme_api::init(configdir!("/acme"), true)?; > > let dir_opts = CreateOptions::new() A similar change is also needed for proxmox-backup-proxy::main because it currently panics during metric_collection::init. Other binaries could be affected as well, but at least the ones that already call proxmox_product_config::init look ok to me.