[PATCH proxmox-backup v3 08/15] pbs-datastore: use proxmox-product-config cached backup user

[Christian Ebner <c.ebner@proxmox.com>]

Instead of looking it up, use the globally cached backup user info
provided by proxmox-product-config. The user is not allowed to change
change anyways during the runtime of the process, as otherwise all
sorts of permission issues can arise.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-datastore/src/datastore.rs | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index e2d1ae67c..06adbece5 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -488,14 +488,15 @@ impl DataStore {
 
                 let (config, _config_digest) = pbs_config::s3::config()?;
                 let config: S3ClientConf = config.lookup(S3_CFG_TYPE_ID, s3_client_id)?;
+                let backup_user = proxmox_product_config::get_api_user();
                 let rate_limiter_options = S3RateLimiterOptions {
                     id: s3_client_id.to_string(),
-                    user: pbs_config::backup_user()?,
+                    user: backup_user.clone(),
                     base_path: S3_CLIENT_RATE_LIMITER_BASE_PATH.into(),
                 };
                 let request_counter_config = S3RequestCounterConfig {
                     id: format!("{s3_client_id}-{bucket}-{}", self.name()),
-                    user: pbs_config::backup_user()?,
+                    user: backup_user.clone(),
                     base_path: S3_CLIENT_REQUEST_COUNTER_BASE_PATH.into(),
                 };
 
@@ -819,8 +820,9 @@ impl DataStore {
                 .ok_or(format_err!("missing s3 bucket"))?,
             config.name,
         );
+        let backup_user = proxmox_product_config::get_api_user();
         let request_counters =
-            SharedRequestCounters::open_shared_memory_mapped(path, pbs_config::backup_user()?)?;
+            SharedRequestCounters::open_shared_memory_mapped(path, backup_user.clone())?;
         Ok(request_counters)
     }
 
@@ -2653,7 +2655,7 @@ impl DataStore {
             let mut path = self.base_path();
             path.push(".gc-status");
 
-            let backup_user = pbs_config::backup_user()?;
+            let backup_user = proxmox_product_config::get_api_user();
             let mode = nix::sys::stat::Mode::from_bits_truncate(0o0644);
             // set the correct owner/group/permissions while saving file
             // owner(rw) = backup, group(r)= backup
@@ -3183,7 +3185,7 @@ impl DataStore {
     // Fetch the contents (metadata, no chunks) of the datastore from the S3 object store to the
     // provided temporaray directory
     async fn fetch_tmp_contents(&self, tmp_base: &Path, s3_client: &S3Client) -> Result<(), Error> {
-        let backup_user = pbs_config::backup_user().context("failed to get backup user")?;
+        let backup_user = proxmox_product_config::get_api_user();
         let mode = nix::sys::stat::Mode::from_bits_truncate(0o0644);
         let file_create_options = CreateOptions::new()
             .perm(mode)
@@ -3336,14 +3338,15 @@ impl DataStore {
         let client_config: S3ClientConf = config
             .lookup(S3_CFG_TYPE_ID, s3_client_id)
             .with_context(|| format!("no '{s3_client_id}' in config"))?;
+        let backup_user = proxmox_product_config::get_api_user();
         let rate_limiter_options = S3RateLimiterOptions {
             id: s3_client_id.to_string(),
-            user: pbs_config::backup_user()?,
+            user: backup_user.clone(),
             base_path: S3_CLIENT_RATE_LIMITER_BASE_PATH.into(),
         };
         let request_counter_config = S3RequestCounterConfig {
             id: format!("{s3_client_id}-{bucket}-{}", datastore_config.name),
-            user: pbs_config::backup_user()?,
+            user: backup_user.clone(),
             base_path: S3_CLIENT_REQUEST_COUNTER_BASE_PATH.into(),
         };
 
-- 
2.47.3