From: Robert Obkircher <r.obkircher@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v3 12/15] tape: use proxmox-product-config helper for user lookup
Date: Mon, 6 Jul 2026 14:28:30 +0200 [thread overview]
Message-ID: <78a80f74-7418-4746-bd87-638ef250c5ee@proxmox.com> (raw)
In-Reply-To: <20260701140412.200920-13-c.ebner@proxmox.com>
On 01.07.26 16:05, Christian Ebner wrote:
> By this the globally cached user information is used instead of doing
> a lookup to be consistent with the rest of the codebase.
>
> Tests are adapted to call the init exactly once by an init callback
> for a LazyLock. This is thread safe, so tests can be run in parallel
> without interference.
>
> [..]
>
> +static PROXMOX_PRODUCT_CONFIG_INIT_FOR_TESTS: LazyLock<bool> = LazyLock::new(|| {
> + proxmox_product_config::init(
> + pbs_config::backup_user().unwrap(),
> + pbs_config::priv_user().unwrap(),
> + );
> + true
> +});
> +
> fn create_testdir(name: &str) -> Result<PathBuf, Error> {
> let mut testdir: PathBuf = String::from("./target/testout").into();
> testdir.push(std::module_path!());
> @@ -22,6 +31,8 @@ fn create_testdir(name: &str) -> Result<PathBuf, Error> {
>
> #[test]
> fn test_alloc_writable_media_1() -> Result<(), Error> {
> + assert_eq!(LazyLock::force(&PROXMOX_PRODUCT_CONFIG_INIT_FOR_TESTS), &true);
> +
>
> [..]
Wouldn't LazyLock<()> without the assert_eq work as well?
next prev parent reply other threads:[~2026-07-06 12:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 14:03 [PATCH proxmox-backup v3 00/15] fix 7642: avoid expensive uid/gid lookups for lock- and config-files Christian Ebner
2026-07-01 14:03 ` [PATCH proxmox-backup v3 01/15] bin: api: early init proxmox-product-config Christian Ebner
2026-07-06 10:06 ` Robert Obkircher
2026-07-01 14:03 ` [PATCH proxmox-backup v3 02/15] bin: daily update: refactor to use proxmox-product-config Christian Ebner
2026-07-01 14:04 ` [PATCH proxmox-backup v3 03/15] pbs-config: use proxmox-product-config::replace_secret_config() Christian Ebner
2026-07-06 12:28 ` Robert Obkircher
2026-07-01 14:04 ` [PATCH proxmox-backup v3 04/15] pbs-config: use proxmox-product-config::replace_config() Christian Ebner
2026-07-06 12:28 ` Robert Obkircher
2026-07-01 14:04 ` [PATCH proxmox-backup v3 05/15] fix #7642: avoid expensive user lookups on file locking Christian Ebner
2026-07-01 14:04 ` [PATCH proxmox-backup v3 06/15] pbs-config: use proxmox-product-config helpers Christian Ebner
2026-07-01 14:04 ` [PATCH proxmox-backup v3 07/15] pbs-config: drop backup_group helper, use users gid instead Christian Ebner
2026-07-06 12:28 ` Robert Obkircher
2026-07-01 14:04 ` [PATCH proxmox-backup v3 08/15] pbs-datastore: use proxmox-product-config cached backup user Christian Ebner
2026-07-01 14:04 ` [PATCH proxmox-backup v3 09/15] pbs-datastore: use general helpers for file lock create options Christian Ebner
2026-07-01 14:04 ` [PATCH proxmox-backup v3 10/15] server: auth helpers: use proxmox-product-config create options helpers Christian Ebner
2026-07-01 14:04 ` [PATCH proxmox-backup v3 11/15] api: subscription: use proxmox-product-config create options Christian Ebner
2026-07-01 14:04 ` [PATCH proxmox-backup v3 12/15] tape: use proxmox-product-config helper for user lookup Christian Ebner
2026-07-06 12:28 ` Robert Obkircher [this message]
2026-07-01 14:04 ` [PATCH proxmox-backup v3 13/15] tape: use proxmox-product-config lock file create options Christian Ebner
2026-07-01 14:04 ` [PATCH proxmox-backup v3 14/15] tape: use proxmox-product-config to generate " Christian Ebner
2026-07-06 12:29 ` Robert Obkircher
2026-07-01 14:04 ` [PATCH proxmox-backup v3 15/15] tree-wide: use proxmox-product-config::get_api_user for user lookup Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78a80f74-7418-4746-bd87-638ef250c5ee@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox