Re: [PATCH proxmox-backup v4 4/9] ui: prune job: align prune edit window to other "Enable" checkboxes

[Christian Ebner <c.ebner@proxmox.com>]

On 10/22/26 6:44 PM, Jonas Theisen wrote:
> Align the already existing "Enabled" checkbox in the prune job edit
> window to the "Enable" checkboxes of the other job types: rename it
> to "Enable", as is more common throughout the UI, add the same
> tooltip, and disable the schedule field while the checkbox is
> unchecked.
> 
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
>   www/window/PruneJobEdit.js | 32 ++++++++++++++++++++++++++++----
>   1 file changed, 28 insertions(+), 4 deletions(-)
> 
> diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
> index a3dafde21..63f736570 100644
> --- a/www/window/PruneJobEdit.js
> +++ b/www/window/PruneJobEdit.js
> @@ -43,6 +43,21 @@ Ext.define('PBS.window.PruneJobEdit', {
>           },
>       },
>   
> +    viewModel: {
> +        data: {
> +            jobEnabled: true,
> +        },
> +    },
> +
> +    setValues: function (values) {
> +        let me = this;
> +
> +        if (!values.schedule) {
> +            values.disable = true;
> +        }
> +        me.callParent([values]);
> +    },
> +
>       items: {
>           xtype: 'inputpanel',
>           onGetValues: function (values) {
> @@ -115,14 +130,23 @@ Ext.define('PBS.window.PruneJobEdit', {
>                   cbind: {
>                       value: '{scheduleValue}',
>                   },
> +                bind: {
> +                    disabled: '{!jobEnabled}',
> +                },
>               },
>               {
>                   xtype: 'proxmoxcheckbox',
> -                fieldLabel: gettext('Enabled'),
> +                fieldLabel: gettext('Enable'),
>                   name: 'enable',
> -                uncheckedValue: 0,
> -                defaultValue: 1,
> -                checked: true,
> +                autoEl: {
> +                    tag: 'div',
> +                    'data-qtip': gettext('Enable scheduled execution of this job.'),
> +                },
> +                bind: {
> +                    value: '{jobEnabled}',
> +                },
> +                uncheckedValue: false,
> +                value: true,

comment: no need to explicitly set the value to true, as the value has 
already the binding to `jobEnabled`.

Further, the onGetValues() and onSetValues() implementation here, used 
to replace `enable` with the `disable` for the submit values might be 
factored out to PBS.Utils and reused for the other job edit windows, as 
introduced by patch 7.

>               },
>           ],
>