Re: [PATCH proxmox v4 2/9] pbs-api-types: prune job: make schedule optional

[Christian Ebner <c.ebner@proxmox.com>]

On 10/22/26 6:44 PM, Jonas Theisen wrote:
> To align the prune job API to the other job types and

nit: no need for the early line break in the commit message.

> to make use of the disable parameter the schedule should be optional.
> If this is not the case a new prune job cannot be created to be
> manually run i.e. disabled without a schedule.
> 
> This also means the schedule should be an Option<String> instead
> of a plain String. This is based on the existing other jobs.
> 
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
>   pbs-api-types/src/jobs.rs | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs
> index 6b725b75..9138596c 100644
> --- a/pbs-api-types/src/jobs.rs
> +++ b/pbs-api-types/src/jobs.rs
> @@ -926,6 +926,7 @@ impl PruneJobOptions {
>               schema: DATASTORE_SCHEMA,
>           },
>           schedule: {
> +            optional: true,
>               schema: PRUNE_SCHEDULE_SCHEMA,
>           },
>           comment: {
> @@ -952,7 +953,8 @@ pub struct PruneJobConfig {
>       #[updater(serde(skip_serializing_if = "Option::is_none"))]
>       pub disable: bool,
>   
> -    pub schedule: String,
> +    #[serde(skip_serializing_if = "Option::is_none")]
> +    pub schedule: Option<String>,
>   
>       #[serde(skip_serializing_if = "Option::is_none")]
>       pub comment: Option<String>,