From: Jonas Theisen <j.theisen@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v4 2/9] pbs-api-types: prune job: make schedule optional
Date: Thu, 22 Oct 2026 18:43:17 +0200 [thread overview]
Message-ID: <20261022164343.353831-3-j.theisen@proxmox.com> (raw)
In-Reply-To: <20261022164343.353831-1-j.theisen@proxmox.com>
To align the prune job API to the other job types and
to make use of the disable parameter the schedule should be optional.
If this is not the case a new prune job cannot be created to be
manually run i.e. disabled without a schedule.
This also means the schedule should be an Option<String> instead
of a plain String. This is based on the existing other jobs.
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
pbs-api-types/src/jobs.rs | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs
index 6b725b75..9138596c 100644
--- a/pbs-api-types/src/jobs.rs
+++ b/pbs-api-types/src/jobs.rs
@@ -926,6 +926,7 @@ impl PruneJobOptions {
schema: DATASTORE_SCHEMA,
},
schedule: {
+ optional: true,
schema: PRUNE_SCHEDULE_SCHEMA,
},
comment: {
@@ -952,7 +953,8 @@ pub struct PruneJobConfig {
#[updater(serde(skip_serializing_if = "Option::is_none"))]
pub disable: bool,
- pub schedule: String,
+ #[serde(skip_serializing_if = "Option::is_none")]
+ pub schedule: Option<String>,
#[serde(skip_serializing_if = "Option::is_none")]
pub comment: Option<String>,
--
2.47.3
next prev parent reply other threads:[~2026-10-22 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 16:43 [PATCH proxmox{,-backup} v4 0/9] fix #7904: Implement Enable checkboxes for all jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox v4 1/9] pbs-api-types: add 'disable' to {sync,verify,tape,gc} job schema and datastore config Jonas Theisen
2026-10-22 16:43 ` Jonas Theisen [this message]
2026-10-22 16:43 ` [PATCH proxmox-backup v4 3/9] server: schedules: add 'disable' parameter to compute_schedule_status() Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 4/9] ui: prune job: align prune edit window to other "Enable" checkboxes Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 5/9] api: prune job: align prune job schedule to other jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 6/9] fix #7904: api: implement "disable" for {sync,verify,tape,GC} jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 7/9] fix #7904: ui: add "Enable" checkbox to {sync,verify,tape,GC} job edit Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 8/9] ui: job overview: show "Disabled" as schedule of disabled jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 9/9] ui: calendar-event: hide clear button if a schedule is required Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022164343.353831-3-j.theisen@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox