public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v4 4/9] ui: prune job: align prune edit window to other "Enable" checkboxes
Date: Thu, 22 Oct 2026 18:43:19 +0200	[thread overview]
Message-ID: <20261022164343.353831-5-j.theisen@proxmox.com> (raw)
In-Reply-To: <20261022164343.353831-1-j.theisen@proxmox.com>

Align the already existing "Enabled" checkbox in the prune job edit
window to the "Enable" checkboxes of the other job types: rename it
to "Enable", as is more common throughout the UI, add the same
tooltip, and disable the schedule field while the checkbox is
unchecked.

Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 www/window/PruneJobEdit.js | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
index a3dafde21..63f736570 100644
--- a/www/window/PruneJobEdit.js
+++ b/www/window/PruneJobEdit.js
@@ -43,6 +43,21 @@ Ext.define('PBS.window.PruneJobEdit', {
         },
     },
 
+    viewModel: {
+        data: {
+            jobEnabled: true,
+        },
+    },
+
+    setValues: function (values) {
+        let me = this;
+
+        if (!values.schedule) {
+            values.disable = true;
+        }
+        me.callParent([values]);
+    },
+
     items: {
         xtype: 'inputpanel',
         onGetValues: function (values) {
@@ -115,14 +130,23 @@ Ext.define('PBS.window.PruneJobEdit', {
                 cbind: {
                     value: '{scheduleValue}',
                 },
+                bind: {
+                    disabled: '{!jobEnabled}',
+                },
             },
             {
                 xtype: 'proxmoxcheckbox',
-                fieldLabel: gettext('Enabled'),
+                fieldLabel: gettext('Enable'),
                 name: 'enable',
-                uncheckedValue: 0,
-                defaultValue: 1,
-                checked: true,
+                autoEl: {
+                    tag: 'div',
+                    'data-qtip': gettext('Enable scheduled execution of this job.'),
+                },
+                bind: {
+                    value: '{jobEnabled}',
+                },
+                uncheckedValue: false,
+                value: true,
             },
         ],
 
-- 
2.47.3





  parent reply	other threads:[~2026-10-22 16:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 16:43 [PATCH proxmox{,-backup} v4 0/9] fix #7904: Implement Enable checkboxes for all jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox v4 1/9] pbs-api-types: add 'disable' to {sync,verify,tape,gc} job schema and datastore config Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox v4 2/9] pbs-api-types: prune job: make schedule optional Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 3/9] server: schedules: add 'disable' parameter to compute_schedule_status() Jonas Theisen
2026-10-22 16:43 ` Jonas Theisen [this message]
2026-10-22 16:43 ` [PATCH proxmox-backup v4 5/9] api: prune job: align prune job schedule to other jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 6/9] fix #7904: api: implement "disable" for {sync,verify,tape,GC} jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 7/9] fix #7904: ui: add "Enable" checkbox to {sync,verify,tape,GC} job edit Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 8/9] ui: job overview: show "Disabled" as schedule of disabled jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 9/9] ui: calendar-event: hide clear button if a schedule is required Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022164343.353831-5-j.theisen@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal