From: Christian Ebner <c.ebner@proxmox.com>
To: Jonas Theisen <j.theisen@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox v4 1/9] pbs-api-types: add 'disable' to {sync,verify,tape,gc} job schema and datastore config
Date: Tue, 27 Oct 2026 12:33:19 +0100 [thread overview]
Message-ID: <4e712d59-1aa8-47a0-a2d4-58bcaac878e7@proxmox.com> (raw)
In-Reply-To: <20261022164343.353831-2-j.theisen@proxmox.com>
On 10/22/26 6:44 PM, Jonas Theisen wrote:
> To be able to en-/disable the respective jobs this patch adds the
> "disable" field to the job config and the needed schema.
>
> This also adds the "gc_disable" parameter to the datastore config
> to allow this type of job to be disabled.
>
> "disable" was chosen over "enable" to be consistent with the already
> existing config and API endpoints for prune jobs.
>
> This commit also aligns the prune job config to make use of
> the new schema but does not modify functionality.
>
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
Does not compile since is_false() implementation is now missing, but
does not apply on top of the series mentioned in the cover letter
either. Maybe best if you just re-implement or cherry pick that patch?
next prev parent reply other threads:[~2026-10-27 11:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 16:43 [PATCH proxmox{,-backup} v4 0/9] fix #7904: Implement Enable checkboxes for all jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox v4 1/9] pbs-api-types: add 'disable' to {sync,verify,tape,gc} job schema and datastore config Jonas Theisen
2026-10-27 11:33 ` Christian Ebner [this message]
2026-10-22 16:43 ` [PATCH proxmox v4 2/9] pbs-api-types: prune job: make schedule optional Jonas Theisen
2026-10-27 12:49 ` Christian Ebner
2026-10-22 16:43 ` [PATCH proxmox-backup v4 3/9] server: schedules: add 'disable' parameter to compute_schedule_status() Jonas Theisen
2026-10-27 11:53 ` Christian Ebner
2026-10-22 16:43 ` [PATCH proxmox-backup v4 4/9] ui: prune job: align prune edit window to other "Enable" checkboxes Jonas Theisen
2026-10-27 12:48 ` Christian Ebner
2026-10-22 16:43 ` [PATCH proxmox-backup v4 5/9] api: prune job: align prune job schedule to other jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 6/9] fix #7904: api: implement "disable" for {sync,verify,tape,GC} jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 7/9] fix #7904: ui: add "Enable" checkbox to {sync,verify,tape,GC} job edit Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 8/9] ui: job overview: show "Disabled" as schedule of disabled jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 9/9] ui: calendar-event: hide clear button if a schedule is required Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e712d59-1aa8-47a0-a2d4-58bcaac878e7@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=j.theisen@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox