Re: [PATCH proxmox{,-backup} 00/11] add GarbageCollection maintenance mode

[Christian Ebner <c.ebner@proxmox.com>]

On 6/2/26 2:59 PM, Robert Obkircher wrote:
> Add a maintenance mode that allows reclaiming storage space without
> the risk of running out of space because of new backups.
> 
> Changes since [RFC]:
> * Excluded the space-check patches. I'll send them separately.
> * Propagate maintenance mode parse errors.
> * Rename Operation::Prune to Operation::WriteNonExpanding.
> * Track them in active operations to display GC mode conflicts.
> * Replace if-else with match in maintenance mode check.
> * Fixed typos and added Bugzilla url trailers.
> 
> [RFC] https://lore.proxmox.com/pbs-devel/20260430150607.330413-1-r.obkircher@proxmox.com/


Tested:
- Maintenance mode GC cannot be set while active backup or other write
   operation.
- Mode is entered when conflicting active operations are finished.
- Restore/singe file restore works while mode is active.
- Verify, prune and GC can be executed while maintenance mode GC is set.
- Protected mode can be set/cleared while maintenance mode active.
- Group and snapshot notes cannot be changed while mode is active.
- Push sync works while mode is active, pull does not.
- Moves fail if mode is set, namespaces can be deleted (inclusive all
   groups) but not created
- Manually editing of maintenance mode to an unknown variant leads to
   errors, showing the corresponding error masks in the ui (noted the 1
   min cache timeout required for config changes to take effect).

Only noticed that the datastore summary panel it might be worth to show 
the maintenance type as well, maybe above or below the estimated full 
and de-duplication factor. Currently only offline datastores are easily 
identified as there they are masked accordingly.

Since the mode can be actively set by users, it should also be added to 
the documentation with a concise description of what operations are 
being blocked in this maintenance mode.

Consider:

Tested-by: Christian Ebner <c.ebner@proxmox.com>