From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CFF2F1FF13B for ; Wed, 03 Jun 2026 15:29:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08729C380; Wed, 3 Jun 2026 15:29:16 +0200 (CEST) Message-ID: <22c7f5f2-c55a-4693-a246-3eecc6efba34@proxmox.com> Date: Wed, 3 Jun 2026 15:28:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox{,-backup} 00/11] add GarbageCollection maintenance mode To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260602130001.217482-1-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260602130001.217482-1-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780493283773 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HRIPZRP7MHWZ5Y2QTR3USOJH2UIQBZJ4 X-Message-ID-Hash: HRIPZRP7MHWZ5Y2QTR3USOJH2UIQBZJ4 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 6/2/26 2:59 PM, Robert Obkircher wrote: > Add a maintenance mode that allows reclaiming storage space without > the risk of running out of space because of new backups. > > Changes since [RFC]: > * Excluded the space-check patches. I'll send them separately. > * Propagate maintenance mode parse errors. > * Rename Operation::Prune to Operation::WriteNonExpanding. > * Track them in active operations to display GC mode conflicts. > * Replace if-else with match in maintenance mode check. > * Fixed typos and added Bugzilla url trailers. > > [RFC] https://lore.proxmox.com/pbs-devel/20260430150607.330413-1-r.obkircher@proxmox.com/ Tested: - Maintenance mode GC cannot be set while active backup or other write operation. - Mode is entered when conflicting active operations are finished. - Restore/singe file restore works while mode is active. - Verify, prune and GC can be executed while maintenance mode GC is set. - Protected mode can be set/cleared while maintenance mode active. - Group and snapshot notes cannot be changed while mode is active. - Push sync works while mode is active, pull does not. - Moves fail if mode is set, namespaces can be deleted (inclusive all groups) but not created - Manually editing of maintenance mode to an unknown variant leads to errors, showing the corresponding error masks in the ui (noted the 1 min cache timeout required for config changes to take effect). Only noticed that the datastore summary panel it might be worth to show the maintenance type as well, maybe above or below the estimated full and de-duplication factor. Currently only offline datastores are easily identified as there they are masked accordingly. Since the mode can be actively set by users, it should also be added to the documentation with a concise description of what operations are being blocked in this maintenance mode. Consider: Tested-by: Christian Ebner