public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup 3/6] www: access active operation fields by name instead of index
Date: Wed, 3 Jun 2026 14:04:29 +0200	[thread overview]
Message-ID: <71bf2ca3-31a6-4696-a5ff-a750ba0f677c@proxmox.com> (raw)
In-Reply-To: <20260602130001.217482-9-r.obkircher@proxmox.com>

On 6/2/26 3:01 PM, Robert Obkircher wrote:
> Avoid relying on (presumably sorted) field order so new fields could
> be added to the API response in the future.
> 
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
>   www/datastore/OptionView.js | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
> index 42a6104dc..64e47aa57 100644
> --- a/www/datastore/OptionView.js
> +++ b/www/datastore/OptionView.js
> @@ -122,8 +122,13 @@ Ext.define('PBS.Datastore.Options', {
>   
>               view.mon(me.activeOperationsRstore, 'load', (store, data, success) => {
>                   let activeTasks = me.getView().maintenanceActiveTasks;
> -                activeTasks.read = data?.[0]?.data.value ?? 0;
> -                activeTasks.write = data?.[1]?.data.value ?? 0;
> +                if (success) {
> +                  activeTasks.read = store.getById('read')?.data.value ?? 0;
> +                  activeTasks.write = store.getById('write')?.data.value ?? 0;
> +                } else {
> +                  activeTasks.read = 0;
> +                  activeTasks.write = 0;
> +                }
>               });
>           },
>   

This introduces formatting issues as reported by `proxmox-biome check www`.




  reply	other threads:[~2026-06-03 12:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 12:58 [PATCH proxmox{,-backup} 00/11] add GarbageCollection maintenance mode Robert Obkircher
2026-06-02 12:58 ` [PATCH proxmox 1/5] pbs-api-types: propagate maintenance mode parse errors Robert Obkircher
2026-06-03 10:33   ` Christian Ebner
2026-06-02 12:58 ` [PATCH proxmox 2/5] pbs-api-types: use match statement for maintenance mode check Robert Obkircher
2026-06-03 10:36   ` Christian Ebner
2026-06-03 11:04     ` Robert Obkircher
2026-06-03 11:30       ` Christian Ebner
2026-06-02 12:58 ` [PATCH proxmox 3/5] pbs-api-types: deny non-lookup operations for unknown modes Robert Obkircher
2026-06-03 10:38   ` Christian Ebner
2026-06-03 11:18     ` Robert Obkircher
2026-06-03 11:38       ` Christian Ebner
2026-06-02 12:58 ` [PATCH proxmox 4/5] pbs-api-types: add WriteNonExpanding datastore operation Robert Obkircher
2026-06-03 10:45   ` Christian Ebner
2026-06-02 12:58 ` [PATCH proxmox 5/5] pbs-api-types: add GarbageCollection maintenance mode Robert Obkircher
2026-06-03 10:50   ` Christian Ebner
2026-06-02 12:58 ` [PATCH proxmox-backup 1/6] datastore: propagate maintenance mode parse errors Robert Obkircher
2026-06-03 11:20   ` Christian Ebner
2026-06-02 12:58 ` [PATCH proxmox-backup 2/6] task tracking: use parameter for initial count and refactor updates Robert Obkircher
2026-06-03 11:58   ` Christian Ebner
2026-06-02 12:58 ` [PATCH proxmox-backup 3/6] www: access active operation fields by name instead of index Robert Obkircher
2026-06-03 12:04   ` Christian Ebner [this message]
2026-06-02 12:59 ` [PATCH proxmox-backup 4/6] task tracking: count WriteNonExpanding datastore operations Robert Obkircher
2026-06-03 12:18   ` Christian Ebner
2026-06-02 12:59 ` [PATCH proxmox-backup 5/6] datastore: open datastores with WriteNonExpanding instead of Write Robert Obkircher
2026-06-03 12:28   ` Christian Ebner
2026-06-02 12:59 ` [PATCH proxmox-backup 6/6] fix #5797: www: display new GarbageCollection maintenance mode Robert Obkircher
2026-06-03 13:03   ` Christian Ebner
2026-06-03 13:28 ` [PATCH proxmox{,-backup} 00/11] add " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71bf2ca3-31a6-4696-a5ff-a750ba0f677c@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=r.obkircher@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal