Re: [PATCH proxmox 3/5] pbs-api-types: deny non-lookup operations for unknown modes

[Robert Obkircher <r.obkircher@proxmox.com>]

On 03.06.26 12:38, Christian Ebner wrote:
> On 6/2/26 3:00 PM, Robert Obkircher wrote:
>> Denying non-lookup operations for unknown modes seems like a safer
>
> s/seems like/is/
>
>> default. This change should not affect anything because the backup
>> server does not enable the enum-fallback feature.
>>
>> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
>> ---
>>   pbs-api-types/src/maintenance.rs | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/pbs-api-types/src/maintenance.rs
>> b/pbs-api-types/src/maintenance.rs
>> index 7def498b..7e9599be 100644
>> --- a/pbs-api-types/src/maintenance.rs
>> +++ b/pbs-api-types/src/maintenance.rs
>> @@ -109,7 +109,7 @@ impl MaintenanceMode {
>>                   bail!("read-only maintenance mode: {message}")
>>               }
>>               #[cfg(feature = "enum-fallback")]
>> -            (MaintenanceType::UnknownEnumValue(_), _) => Ok(()),
>> +            (MaintenanceType::UnknownEnumValue(m), _) =>
>> bail!("unknown maintenance mode: {m}"),
>
> What about PDM? I didn't recompile PDM with your changes on top, but
> code wise the DatastorePanelComp currently only checks for offline
> stores. Probably contents should not be shown if the maintenance
> mode is unknown there (although pre-existing). 
Does it ever call that function? I couldn't find anything but my lsp
is not always reliable.

This comparison [1] seems wrong if the mode has a message.

[1]
https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=blob;f=ui/src/pbs/datastore.rs;h=53be35bcb747561ef8855b1efc9d6c131f516117;hb=HEAD#l52

>
>>           }
>>       }
>>   }
>