Re: [PATCH proxmox 3/5] pbs-api-types: deny non-lookup operations for unknown modes

[Christian Ebner <c.ebner@proxmox.com>]

On 6/2/26 3:00 PM, Robert Obkircher wrote:
> Denying non-lookup operations for unknown modes seems like a safer

s/seems like/is/

> default. This change should not affect anything because the backup
> server does not enable the enum-fallback feature.
> 
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
>   pbs-api-types/src/maintenance.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs
> index 7def498b..7e9599be 100644
> --- a/pbs-api-types/src/maintenance.rs
> +++ b/pbs-api-types/src/maintenance.rs
> @@ -109,7 +109,7 @@ impl MaintenanceMode {
>                   bail!("read-only maintenance mode: {message}")
>               }
>               #[cfg(feature = "enum-fallback")]
> -            (MaintenanceType::UnknownEnumValue(_), _) => Ok(()),
> +            (MaintenanceType::UnknownEnumValue(m), _) => bail!("unknown maintenance mode: {m}"),

What about PDM? I didn't recompile PDM with your changes on top, but 
code wise the DatastorePanelComp currently only checks for offline 
stores. Probably contents should not be shown if the maintenance mode is 
unknown there (although pre-existing).

>           }
>       }
>   }