[PATCH proxmox-backup] verify: wait for decoder pool to complete before fetching error state

[PATCH proxmox-backup] verify: wait for decoder pool to complete before fetching error state

[Christian Ebner]

The decoder pool must be explicitley run to completion before
determining the error and statistics state to be propagated,
otherwise a race condition with still ongoing chunk verifictaion is
present, which can lead to setting an incorrect verification state
for a snapshot.

This was incorrectly replaced by completing the reader pool when
parallel chunk readers were introduced, it should have extended it
instead.

Fixes: b56a0c20a ("verify: move chunk loading into parallel handler")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/backup/verify.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/backup/verify.rs b/src/backup/verify.rs
index aeb78c032..43bee6a36 100644
--- a/src/backup/verify.rs
+++ b/src/backup/verify.rs
@@ -221,6 +221,7 @@ impl VerifyWorker {
         }
 
         reader_pool.complete()?;
+        decoder_pool.complete()?;
 
         let elapsed = verify_state.start_time.elapsed().as_secs_f64();
 
-- 
2.47.3

applied: [PATCH proxmox-backup] verify: wait for decoder pool to complete before fetching error state

[Thomas Lamprecht]

On Mon, 09 Nov 2026 17:54:52 +0100, Christian Ebner wrote:
> The decoder pool must be explicitley run to completion before
> determining the error and statistics state to be propagated,
> otherwise a race condition with still ongoing chunk verifictaion is
> present, which can lead to setting an incorrect verification state
> for a snapshot.
> 
> This was incorrectly replaced by completing the reader pool when
> parallel chunk readers were introduced, it should have extended it
> instead.
> 
> [...]

Applied, thanks!

[1/1] verify: wait for decoder pool to complete before fetching error state
      commit: 87ee5ecf67f90e6a3d00131abfe5123a7e81e62f