From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup] verify: wait for decoder pool to complete before fetching error state
Date: Mon, 9 Nov 2026 17:54:52 +0100 [thread overview]
Message-ID: <20261109165452.176946-1-c.ebner@proxmox.com> (raw)
The decoder pool must be explicitley run to completion before
determining the error and statistics state to be propagated,
otherwise a race condition with still ongoing chunk verifictaion is
present, which can lead to setting an incorrect verification state
for a snapshot.
This was incorrectly replaced by completing the reader pool when
parallel chunk readers were introduced, it should have extended it
instead.
Fixes: b56a0c20a ("verify: move chunk loading into parallel handler")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
src/backup/verify.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/backup/verify.rs b/src/backup/verify.rs
index aeb78c032..43bee6a36 100644
--- a/src/backup/verify.rs
+++ b/src/backup/verify.rs
@@ -221,6 +221,7 @@ impl VerifyWorker {
}
reader_pool.complete()?;
+ decoder_pool.complete()?;
let elapsed = verify_state.start_time.elapsed().as_secs_f64();
--
2.47.3
next reply other threads:[~2026-11-09 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 16:54 Christian Ebner [this message]
2026-11-09 23:30 ` applied: [PATCH proxmox-backup] verify: wait for decoder pool to complete before fetching error state Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109165452.176946-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox