From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1E86E1FF09B for ; Mon, 09 Nov 2026 17:55:10 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4B5B020AD8; Mon, 09 Nov 2026 17:55:09 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] verify: wait for decoder pool to complete before fetching error state Date: Mon, 9 Nov 2026 17:54:52 +0100 Message-ID: <20261109165452.176946-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794243304206 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.432 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3G5L4IEFODSVJAHEKEZ4ZBUGL4PVJE5J X-Message-ID-Hash: 3G5L4IEFODSVJAHEKEZ4ZBUGL4PVJE5J X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The decoder pool must be explicitley run to completion before determining the error and statistics state to be propagated, otherwise a race condition with still ongoing chunk verifictaion is present, which can lead to setting an incorrect verification state for a snapshot. This was incorrectly replaced by completing the reader pool when parallel chunk readers were introduced, it should have extended it instead. Fixes: b56a0c20a ("verify: move chunk loading into parallel handler") Signed-off-by: Christian Ebner --- src/backup/verify.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/backup/verify.rs b/src/backup/verify.rs index aeb78c032..43bee6a36 100644 --- a/src/backup/verify.rs +++ b/src/backup/verify.rs @@ -221,6 +221,7 @@ impl VerifyWorker { } reader_pool.complete()?; + decoder_pool.complete()?; let elapsed = verify_state.start_time.elapsed().as_secs_f64(); -- 2.47.3