From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 95E821FF0B0 for ; Tue, 10 Nov 2026 00:30:53 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B2D7E214DB; Tue, 10 Nov 2026 00:30:52 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup] verify: wait for decoder pool to complete before fetching error state Date: Tue, 10 Nov 2026 00:30:40 +0100 Message-ID: <179426703544.1380704.7184248311517679824.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261109165452.176946-1-c.ebner@proxmox.com> References: <20261109165452.176946-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794267048023 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.273 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GWKV6T7KM7UPNEXX4QB7PH6UIOMQWHS5 X-Message-ID-Hash: GWKV6T7KM7UPNEXX4QB7PH6UIOMQWHS5 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 09 Nov 2026 17:54:52 +0100, Christian Ebner wrote: > The decoder pool must be explicitley run to completion before > determining the error and statistics state to be propagated, > otherwise a race condition with still ongoing chunk verifictaion is > present, which can lead to setting an incorrect verification state > for a snapshot. > > This was incorrectly replaced by completing the reader pool when > parallel chunk readers were introduced, it should have extended it > instead. > > [...] Applied, thanks! [1/1] verify: wait for decoder pool to complete before fetching error state commit: 87ee5ecf67f90e6a3d00131abfe5123a7e81e62f