Re: [PATCH v3 00/10] app: implement OpenID Connect (OAuth) realm login (#4281)

["Shan Shaji" <s.shaji@proxmox.com>]

Hi Azharul,

Please don't send a v4 promptly, as I am doing another round of testing.
I will get back once I am done with the testing and code review. Also, Sorry
for not mentioning about the continue button issue in my v2 reviews.

On Fri Aug 21, 2026 at 5:41 AM CEST, Azharul Haque wrote:
> The native Flutter "Proxmox VE Companion" app never implemented OpenID
> Connect / OAuth realm login (bug #4281[0]): selecting an OAuth realm
> just showed username/password fields that could never work.
>
> v3: addresses review feedback on v2, still as a single combined series
> across the three affected repositories:
>
>   - dart-api-client: PveAccessDomainModel.type is now a built_value
>     EnumClass (PveAccessDomainType) instead of a plain String, and the
>     OpenID ticket-parsing helper's regex/dedup issue is fixed.
>   - login-manager: the single large "add OpenID Connect login flow"
>     patch is split into five, dependency, _finishLogin refactor,
>     password-form widget extraction, the OpenID feature itself, and
>     the pre-existing Continue-button fix, and print()/print(trace)
>     calls copied into the new OpenID error handling are removed.
>   - flutter-frontend: the manifest change is split into three,
>     generated-file regeneration, the taskAffinity tweak, and the
>     CallbackActivity registration itself.
>   - Both repos' "rename the callback scheme" follow-up patches from v2
>     are gone entirely: the final scheme (com.proxmox.app, further
>     shortened per your follow-up on the login-manager v2 3/3 patch) is
>     now introduced directly wherever it first appears.
>   - All lockfiles/generated files are regenerated against Flutter
>     3.41 / Dart 3.11 to match this project's toolchain, rather than
>     the newer local Flutter version v2 was inadvertently built with.
>
> Verified end-to-end against a real PVE server with an Authentik OIDC
> realm, on both Android and iOS, plus flutter analyze/test/format under
> Flutter 3.41 across all three repos, plus a real Android Gradle build
> of the modified manifest.
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4281
>
> Azharul Haque (10):
>   fix #4281: access: add `type` property to `PveAccessDomainModel`
>   fix #4281: access: add OpenID Connect auth-url/login helpers
>   fix #4281: deps: add flutter_web_auth_2 dependency
>   refactor: ui: factor out shared login tail into _finishLogin
>   refactor: ui: split password form into its own widget
>   fix #4281: ui: add OpenID Connect login flow to login form
>   fix #4281: ui: fix stale Continue button state on realm switch
>   chore: regenerate plugin registrant for flutter_web_auth_2
>   fix #4281: android: set taskAffinity="" on MainActivity
>   fix #4281: android: register OpenID Connect callback activity
>
> --
> 2.50.1 (Apple Git-155)