Re: [PATCH login-manager v3 2/5] refactor: ui: factor out shared login tail into _finishLogin

["Shan Shaji" <s.shaji@proxmox.com>]

On Fri Aug 21, 2026 at 5:41 AM CEST, Azharul Haque wrote:
> Move the code that runs after an authenticated API client exists --
> handling a pending TFA challenge, fetching cluster status, persisting
> the login and closing the login page -- out of _onLoginButtonPressed
> into a _finishLogin method. No functional change.
>
> This prepares for the OpenID Connect login flow added in a following
> commit, which obtains its client through a browser-based flow instead
> of a password but finishes the login the same way.
>
> Suggested-by: Shan Shaji <s.shaji@proxmox.com>
> Signed-off-by: Azharul Haque <haque@azharul.com>
> ---
>  lib/proxmox_login_form.dart | 203 ++++++++++++++++++++----------------
>  1 file changed, 111 insertions(+), 92 deletions(-)
>
> diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
> index 5b9a64e..6039407 100644
> --- a/lib/proxmox_login_form.dart
> +++ b/lib/proxmox_login_form.dart
> @@ -478,98 +478,13 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
>        var client = await proxclient.authenticate(
>            '$username@$realm', password, origin, settings.sslValidation!);
>
> -      if (client.credentials.tfa != null &&
> -          client.credentials.tfa!.kinds().isNotEmpty) {
> -        if (!mounted) return;
> -        ProxmoxApiClient? tfaclient =
> -            await Navigator.of(context).push(MaterialPageRoute(
> -          builder: (context) => ProxmoxTfaForm(
> -            apiClient: client,
> -          ),
> -        ));
> -
> -        if (tfaclient != null) {
> -          client = tfaclient;
> -        } else {
> -          setState(() {
> -            _progressModel.inProgress -= 1;
> -          });

Updating this progress state is missing in the factored out block. Can
I please know why this was removed?

> -          return;
> -        }
> -      }
> -

[snip]

> +      await _finishLogin(
> +        client,
> +        realm: realm!,
> +        username: username,
> +        enteredPassword: enteredPassword,
> +        savedPassword: savedPassword,
> +      );
>      } on proxclient.ProxmoxApiException catch (e) {
>        print(e);
>        if (!mounted) return;
> @@ -618,6 +533,110 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
>      });
>    }
>
> +  /// Common tail of the login flow once an authenticated client exists:
> +  /// handles a pending TFA challenge, fetches cluster status, persists the
> +  /// login and closes the login page. Returns early (without closing the
> +  /// page) if the user cancels a TFA challenge.
> +  Future<void> _finishLogin(
> +    ProxmoxApiClient client, {
> +    required String realm,
> +    required String username,
> +    String enteredPassword = '',
> +    String? savedPassword,
> +  }) async {
> +    if (client.credentials.tfa != null &&
> +        client.credentials.tfa!.kinds().isNotEmpty) {
> +      if (!mounted) return;
> +      ProxmoxApiClient? tfaclient =
> +          await Navigator.of(context).push(MaterialPageRoute(
> +        builder: (context) => ProxmoxTfaForm(
> +          apiClient: client,
> +        ),
> +      ));
> +
> +      if (tfaclient != null) {
> +        client = tfaclient;
> +      } else {

I meant here.

> +        return;
> +      }
> +    }
> +
> +    final status = await client.getClusterStatus();
> +    final hostname =
> +        status.singleWhereOrNull((element) => element.local ?? false)?.name;
> +    var loginStorage = await ProxmoxLoginStorage.fromLocalStorage();
> +

[snip]