Re: [PATCH dart-api-client v2 1/2] fix #4281: access: add `type` property to `PveAccessDomainModel`

["Shan Shaji" <s.shaji@proxmox.com>]

Hi  Azharul,

On Fri Aug 21, 2026 at 4:56 AM CEST, Azharul Haque wrote:
> Hi Shan,
>
>
> I went with PveAccessDomainType to match this repo's existing convention
> for this kind of enum (PveNodesDiskListType, PveTaskLogStatusType, etc.).
> Happy to switch it to Proxmox... if you'd prefer, just let me know and I'll
> send a follow-up.

PveAccessDomainType should be fine here. Thanks for double checking it. I used
the "Proxmox.." prefix because the access domain types are common across proxmox
products, also that was an example :). 

> Also, my earlier reply on this thread got held by the list for moderator
> approval since I'm not yet a subscribed member, so if it looked like it
> only reached you directly, that's why, not a delivery failure on my end.

Ahh, Sorry! Somehow overlooked it. Thanks for letting me know. 

>
> v3 with this and the rest of your feedback is on its way.
>
>
> Best,
>
> Azharul
>
> On Thu, Aug 20, 2026 at 10:39 AM Shan Shaji <s.shaji@proxmox.com> wrote:
>
>> Hi, thank you very much for agreeing to incorporate my feedbacks.
>> If possible, please also send future replies to the mailling list as
>> well to ensure better visibility.
>>
>> On Thu Aug 20, 2026 at 3:37 PM CEST, Azharul Haque wrote:
>> > Hi Shan,
>> >
>> >
>> > Thanks for testing against Keycloak, glad to hear it worked cleanly end
>> to
>> > end.
>> >
>> > Good call on the enum. I'll switch PveAccessDomainModel.type to a
>> > ProxmoxAccessDomainType EnumClass along the lines you sketched, and
>> update
>> > isOpenIdRealm to compare against it. I'll fold this into a v3 alongside
>> the
>> > other feedback (the login-manager patch split, the regex/dedup fix on the
>> > OpenID login helpers, and the pubspec/Flutter version issue you flagged)
>> > and send it tonight.
>> >
>> >
>> > Thanks again for the quick, thorough review.
>> >
>> >
>> > Best,
>> >
>> > Azharul
>> >
>>
>>