Re: [PATCH dart-api-client v2 1/2] fix #4281: access: add `type` property to `PveAccessDomainModel`

["Shan Shaji" <s.shaji@proxmox.com>]

Hi,

Thank you so much for working on this. I did a round of testing
using keycloak and everything did worked well. Some comments inline. 

On Mon Aug 10, 2026 at 4:47 PM CEST, Azharul Haque wrote:
> The realm/domain list returned by /access/domains always includes a
> `type` field (pam, pve, ldap, ad, openid, ...), but the model never
> captured it. Without it, callers have no way to tell an OpenID Connect
> realm apart from a password-based one, which is why the login form
> falls back to showing username/password fields even for realms that
> require a browser-based OpenID login.
>
> Add the property and an `isOpenIdRealm` convenience getter, used by
> the login form in the following commits.
>
> Signed-off-by: Azharul Haque <haque@azharul.com>
> ---
>  lib/src/models/pve_access_domain_model.dart | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/src/models/pve_access_domain_model.dart b/lib/src/models/pve_access_domain_model.dart
> index 6298bbe..a2fff31 100644
> --- a/lib/src/models/pve_access_domain_model.dart
> +++ b/lib/src/models/pve_access_domain_model.dart
> @@ -7,12 +7,14 @@ abstract class PveAccessDomainModel
>      implements Built<PveAccessDomainModel, PveAccessDomainModelBuilder> {
>    // Fields
>    String get realm;
> +  String get type;

Instead of string type, wouldn't it be better to use an enum here as it's
a fixed list of options?

Like:

class ProxmoxAccessDomainType extends EnumClass {
  static const ProxmoxAccessDomainType openid = _$openid;
  static const ProxmoxAccessDomainType pve = _$pve;
  static const ProxmoxAccessDomainType pam = _$pam;

  const ProxmoxAccessDomainType._(String name) : super(name);

  static BuiltSet<ProxmoxAccessDomainType> get values => _$pveAccessDomainTypeValues;
  static ProxmoxAccessDomainType valueOf(String name) => _$pveAccessDomainTypeValueOf(name);
  static Serializer<ProxmoxAccessDomainType> get serializer => _$pveAccessDomainTypeSerializer;
}

>    String? get comment;
>    String? get tfa;
>    @BuiltValueField(wireName: 'default')
>    int? get defaultValue;
>  
>    bool get isDefaultRealm => defaultValue == 1;
> +  bool get isOpenIdRealm => type == 'openid';
>    PveAccessDomainModel._();
>